[GitHub] [incubator-doris] chenlinzhong commented on a diff in pull request #9245: [Bug] (fix) DeltaWriter::mem_consumption() coredump

[GitBox <gi...@apache.org>]

chenlinzhong commented on code in PR #9245:
URL: https://github.com/apache/incubator-doris/pull/9245#discussion_r859684743


##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -216,12 +216,12 @@ Status TabletsChannel::reduce_mem_usage(int64_t mem_limit) {
     // Sort the DeltaWriters by mem consumption in descend order.
     std::vector<DeltaWriter*> writers;
     for (auto& it : _tablet_writers) {
+        it.second->save_mem_consumption_snapshot();

Review Comment:
   > What's the core reason?
   
   mem_consumption() returned value may be changed during sort period for same element, this does not meet comp requirements



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org