You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2016/02/17 18:07:24 UTC

svn commit: r1730876 - /uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/FeatureStructureImplC.java

Author: schor
Date: Wed Feb 17 17:07:24 2016
New Revision: 1730876

URL: http://svn.apache.org/viewvc?rev=1730876&view=rev
Log:
[UIMA-4674] performance versions that eliminate redundant checking

Modified:
    uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/FeatureStructureImplC.java

Modified: uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/FeatureStructureImplC.java
URL: http://svn.apache.org/viewvc/uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/FeatureStructureImplC.java?rev=1730876&r1=1730875&r2=1730876&view=diff
==============================================================================
--- uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/FeatureStructureImplC.java (original)
+++ uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/cas/impl/FeatureStructureImplC.java Wed Feb 17 17:07:24 2016
@@ -1115,6 +1115,12 @@ public class FeatureStructureImplC imple
     throw new CASRuntimeException(CASRuntimeException.INTERNAL_ERROR); // dummy, always overridden
   }
   
+  /**
+   * Internal Use only
+   * @param slotKind -
+   * @param fi -
+   * @param v -
+   */
   public void setIntLikeValue(SlotKind slotKind, FeatureImpl fi, int v) {
     switch(slotKind) {
     case Slot_Boolean: setBooleanValue(fi, v == 1); break;
@@ -1127,7 +1133,26 @@ public class FeatureStructureImplC imple
   }
   
   /**
+   * Internal Use only - no feature check, no journaling
+   * @param slotKind -
+   * @param fi -
+   * @param v -
+   */
+  public void setIntLikeValueNcNj(SlotKind slotKind, FeatureImpl fi, int v) {
+    switch(slotKind) {
+    case Slot_Boolean: setBooleanValueNcNj(fi, v == 1); break;
+    case Slot_Byte: setByteValueNcNj(fi, (byte) v); break;
+    case Slot_Short: setShortValueNcNj(fi, (short) v); break;
+    case Slot_Int: setIntValueNcNj(fi, v); break;
+    case Slot_Float: setFloatValueNcNj(fi, CASImpl.int2float(v)); break;
+    default: Misc.internalError();
+    }
+  }
+
+  
+  /**
    * for compressed form 4 - for getting the prev value of int-like slots
+   * Uses unchecked forms for feature access
    * @param slotKind
    * @param fi
    * @param v
@@ -1165,11 +1190,11 @@ public class FeatureStructureImplC imple
     }
     
     switch(slotKind) {
-    case Slot_Boolean: return getBooleanValue(f) ? 1 : 0;
-    case Slot_Byte: return getByteValue(f);
-    case Slot_Short: return getShortValue(f);
-    case Slot_Int: return getIntValue(f);
-    case Slot_Float: return CASImpl.float2int(getFloatValue(f));
+    case Slot_Boolean: return getBooleanValueNc(f) ? 1 : 0;
+    case Slot_Byte: return getByteValueNc(f);
+    case Slot_Short: return getShortValueNc(f);
+    case Slot_Int: return getIntValueNc(f);
+    case Slot_Float: return CASImpl.float2int(getFloatValueNc(f));
     default: Misc.internalError(); return 0;
     }
   }