[GitHub] [tvm-rfcs] Mousius commented on pull request #29: Migrating Target Attributes to IRModule

[GitBox <gi...@apache.org>]

Mousius commented on pull request #29:
URL: https://github.com/apache/tvm-rfcs/pull/29#issuecomment-924748001


   Thanks for the feedback @junrushao1994, @areusch, @tkonolige and @mbs-octoml, this is one of those design decisions where I was 50/50 on whether to keep `relay.build` minimal or to leverage it's existing capability as a factory function. I've amended the design to the alternative which hides most of the `IRModule` details behind `relay.build` which I agree is a better interface design:
   
   ```py
   tvm.relay.build(
       ir_module,
       target,
       target_host=target,
       executor=Executor({
         "kind": "aot",
         "unpacked-api": False
       }),
       runtime=Runtime({
         "kind": "c",
         "link-params": False
       }),
       params=params,
       mod_name="the_ultimate_cat_spotter",
   )
   ```
   
   Hopefully this addresses everyone's concerns :smile_cat: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org