[GitHub] spark pull request: [SPARK-12081] Make unified memory manager work...

[jcsalterego <gi...@git.apache.org>]

Github user jcsalterego commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10081#discussion_r53967310
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala ---
    @@ -144,8 +150,16 @@ object UnifiedMemoryManager {
        * Return the total amount of memory shared between execution and storage, in bytes.
        */
       private def getMaxMemory(conf: SparkConf): Long = {
    -    val systemMaxMemory = conf.getLong("spark.testing.memory", Runtime.getRuntime.maxMemory)
    +    val systemMemory = conf.getLong("spark.testing.memory", Runtime.getRuntime.maxMemory)
    +    val reservedMemory = conf.getLong("spark.testing.reservedMemory",
    +      if (conf.contains("spark.testing")) 0 else RESERVED_SYSTEM_MEMORY_BYTES)
    +    val minSystemMemory = reservedMemory * 1.5
    +    if (systemMemory < minSystemMemory) {
    +      throw new IllegalArgumentException(s"System memory $systemMemory must " +
    +        s"be at least $minSystemMemory. Please use a larger heap size.")
    --- End diff --
    
    This comes out as scientific notation, which made me laugh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org