You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/23 13:24:28 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
weizhouapache opened a new pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160
### Description
This PR fixes https://github.com/apache/cloudstack/issues/6084
The global setting system.vm.default.hypervisor will be the first option when deploy VRs.
If it is not set, use the hypervisor type of cluster as 2nd option.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076478272
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076372728
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076499592
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076459602
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076501950
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1077004301
<b>Trillian test result (tid-3708)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37228 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6160-t3708-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_disable_oobm_ha_state_ineligible | `Error` | 1511.94 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1081561384
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1077348587
> LGTM - but needs testing. @weizhouapache pl check if a marvin test covers this case; otherwise a new test case maybe added or manual test confirmation needed.
@rohityadavcloud
thanks for review.
I have manually tested it, but it would be good if someone else test it as well. cc @borisstoyanov @nvazquez
marvin test looks difficult because all hosts have same hypervisor type in each trillian environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076478778
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6160: server: honor global setting system.vm.default.hypervisor as first option when deploy VRs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6160:
URL: https://github.com/apache/cloudstack/pull/6160#issuecomment-1076500619
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org