You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Mario Ivankovits (JIRA)" <ji...@apache.org> on 2010/05/04 11:03:56 UTC
[jira] Created: (VFS-307) VFS issues a lot of FTP commands when
listing a directory
VFS issues a lot of FTP commands when listing a directory
---------------------------------------------------------
Key: VFS-307
URL: https://issues.apache.org/jira/browse/VFS-307
Project: Commons VFS
Issue Type: Improvement
Reporter: Mario Ivankovits
Hello Mario,
We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph.
So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST <relpath>'?
Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this.
Thanks a lot in advance,
Kirill Safonov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-307) VFS issues a lot of FTP commands when
listing a directory
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863727#action_12863727 ]
Mario Ivankovits commented on VFS-307:
--------------------------------------
The change happened when implementing the umbrella issue [1] more concret it was the issue [2] for which we did this.
Hmmm ...
So, I see three ways to move on:
1) leave as is, which surely is a performance penalty and not good for any DIE
2) change to try first LIST <path> and fallback to the current way if directory is not found
3) change to LIST <path> and try to "escape" the path in a way which makes it work with spaces in it
I'll try to see if I can make 3 work and go up the list then .... :-)
> VFS issues a lot of FTP commands when listing a directory
> ---------------------------------------------------------
>
> Key: VFS-307
> URL: https://issues.apache.org/jira/browse/VFS-307
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Mario Ivankovits
>
> Hello Mario,
>
> We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph.
>
> So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST <relpath>'?
>
> Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this.
>
> Thanks a lot in advance,
>
> Kirill Safonov
> JetBrains, Inc
> http://www.jetbrains.com
> "Develop with pleasure!"
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-307) VFS issues a lot of FTP commands when
listing a directory
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863765#action_12863765 ]
Mario Ivankovits commented on VFS-307:
--------------------------------------
It seems there is no FTP spec which allows to escape/quote a path so that it works on each and every ftp server.
So I landed at solution 2 similar to what the patch in VFS-123 proposed. It seems to work with my ftp server.
> VFS issues a lot of FTP commands when listing a directory
> ---------------------------------------------------------
>
> Key: VFS-307
> URL: https://issues.apache.org/jira/browse/VFS-307
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Mario Ivankovits
> Fix For: Nightly Builds
>
>
> Hello Mario,
>
> We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph.
>
> So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST <relpath>'?
>
> Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this.
>
> Thanks a lot in advance,
>
> Kirill Safonov
> JetBrains, Inc
> http://www.jetbrains.com
> "Develop with pleasure!"
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-307) VFS issues a lot of FTP commands when
listing a directory
Posted by "Kirill Safonov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863749#action_12863749 ]
Kirill Safonov commented on VFS-307:
------------------------------------
[1] VFS-210
[2] VFS-123
> VFS issues a lot of FTP commands when listing a directory
> ---------------------------------------------------------
>
> Key: VFS-307
> URL: https://issues.apache.org/jira/browse/VFS-307
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Mario Ivankovits
>
> Hello Mario,
>
> We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph.
>
> So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST <relpath>'?
>
> Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this.
>
> Thanks a lot in advance,
>
> Kirill Safonov
> JetBrains, Inc
> http://www.jetbrains.com
> "Develop with pleasure!"
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (VFS-307) VFS issues a lot of FTP commands when
listing a directory
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mario Ivankovits resolved VFS-307.
----------------------------------
Fix Version/s: Nightly Builds
Resolution: Fixed
Please give it a try
> VFS issues a lot of FTP commands when listing a directory
> ---------------------------------------------------------
>
> Key: VFS-307
> URL: https://issues.apache.org/jira/browse/VFS-307
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Mario Ivankovits
> Fix For: Nightly Builds
>
>
> Hello Mario,
>
> We at JetBrains are implementing support for (S)FTP sync in our IDEs using Commons VFS. When looking at the performance, we noticed that FTP provider is somewhat not perfect: see my discussion with Ralph.
>
> So the question is: why FtpClientWrapper changes the current directory to issue 'LIST' command and restoring it back afterwards instead of issuing single 'LIST <relpath>'?
>
> Subversion says it was you who introduced this behavior far back in 2008. Hope you remember those times and reason why you did this.
>
> Thanks a lot in advance,
>
> Kirill Safonov
> JetBrains, Inc
> http://www.jetbrains.com
> "Develop with pleasure!"
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.