You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/02/26 03:00:29 UTC

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22547


Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................

IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

EventProcessorUtils.wait_for_event_processing() is used in tests to wait
for HMS events being processed by catalogd and all impalads receive the
catalog updates. Currently, the timeout in waiting for catalog updates
is 10s. However, there are some e2e tests like
test_overlap_min_max_filters that run DDL/DMLs longer than 10s, which
could block the catalog update for longer than 10s. When this util
method is used in e2e tests, it could be impacted by other concurrent
tests and time out.

This patch deflake the issue by bumping the timeout to be 20s.

Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
---
M tests/util/event_processor_utils.py
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/22547/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11516/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 17:20:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11516/


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:40:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 17:19:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 2: Verified+1

Merging this since only an unrelated flaky test failed.


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:29:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 17:20:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 2:

> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11516/

The failure is unrelated to this patch:
https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/4644/testReport/junit/org.apache.impala.customcluster/JwtHttpTest/testJwtAuthWithTrustedJwksHttpsUrlInvalidCN/

It's tracked in IMPALA-13546


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:52:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................

IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

EventProcessorUtils.wait_for_event_processing() is used in tests to wait
for HMS events being processed by catalogd and all impalads receive the
catalog updates. Currently, the timeout in waiting for catalog updates
is 10s. However, there are some e2e tests like
test_overlap_min_max_filters that run DDL/DMLs longer than 10s, which
could block the catalog update for longer than 10s. When this util
method is used in e2e tests, it could be impacted by other concurrent
tests and time out.

This patch deflake the issue by bumping the timeout to be 20s.

Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Reviewed-on: http://gerrit.cloudera.org:8080/22547
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M tests/util/event_processor_utils.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18380/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 03:29:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13799: Bumps timeout in waiting for catalog updates in tests

Posted by "Xuebin Su (Code Review)" <ge...@cloudera.org>.
Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22547 )

Change subject: IMPALA-13799: Bumps timeout in waiting for catalog updates in tests
......................................................................


Patch Set 1: Code-Review+1

Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/22547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a785e6d98572bf1a3fa3efc81d712c7ecc488e
Gerrit-Change-Number: 22547
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 03:25:40 +0000
Gerrit-HasComments: No