You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/05/25 23:15:00 UTC

[GitHub] [thrift] Jens-G edited a comment on pull request #2395: THRIFT-5419: Update TThreadPoolAsyncServer.Execute to be async/await

Jens-G edited a comment on pull request #2395:
URL: https://github.com/apache/thrift/pull/2395#issuecomment-848331187


   I'm not fully convinced. The patch is good, that's not the point. 
   
   What I am missing is a test case that clearly shows the issue you are reporting. I just added the threadpool server impl to the Test Suite (PR currently building) and ran both the old code and the patched code with a varying set of parameters and clients against it. However, I still struggle to reproduce the "dramatic poor performance". Could you elaborate more on that? How can I test that in a possibly simple way?
   
   Also, I slightly changed the proposed patch, please find [my version here](https://github.com/Jens-G/thrift/tree/THRIFT-5419).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org