You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/01/21 23:43:54 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #19774: differentiate nightly docker image tags
mseth10 opened a new pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774
## Description ##
Currently CD docker image pipelines for both master and v1.x branches use the same docker tag to publish docker images to dockerhub, which basically overwrites each other every time. Adding "1.x_" prefix to the 1.x branch image tags to fix this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19774: differentiate nightly docker image tags
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#issuecomment-775260308
we could also consider publishing nightly tags to ECR and make them available to only developers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #19774: [v1.x] Fix nightly CD for python docker image releases
Posted by GitBox <gi...@apache.org>.
waytrue17 commented on a change in pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#discussion_r585152076
##########
File path: cd/Jenkinsfile_utils.groovy
##########
@@ -19,16 +19,16 @@
// Triggers a downstream jenkins job responsible for building, testing
// and publishing all the variants for a particular 'job_type'.
-// The 'job_type' should be the name of the directory that contains the
-// 'Jenkins_pipeline.groovy' file and has the pipeline definition for the
+// The 'job_type' should be the name of the directory that contains the
+// 'Jenkins_pipeline.groovy' file and has the pipeline definition for the
// artifact (docker image, binary, pypi or maven package, etc.) that should
// be published.
STATE_UPDATE="State Update"
-def trigger_release_job(job_name, job_type, mxnet_variants) {
+def trigger_release_job(cd_release_job, job_name, job_type, mxnet_variants) {
Review comment:
Curious, why do we pass the cd_release_job instead of using the env var?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19774: differentiate nightly docker image tags
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#issuecomment-765012357
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, website, centos-cpu, edge, unix-gpu, sanity, windows-cpu, unix-cpu, miscellaneous, centos-gpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #19774: [v1.x] Fix nightly CD for python docker image releases
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#discussion_r585181937
##########
File path: cd/Jenkinsfile_utils.groovy
##########
@@ -19,16 +19,16 @@
// Triggers a downstream jenkins job responsible for building, testing
// and publishing all the variants for a particular 'job_type'.
-// The 'job_type' should be the name of the directory that contains the
-// 'Jenkins_pipeline.groovy' file and has the pipeline definition for the
+// The 'job_type' should be the name of the directory that contains the
+// 'Jenkins_pipeline.groovy' file and has the pipeline definition for the
// artifact (docker image, binary, pypi or maven package, etc.) that should
// be published.
STATE_UPDATE="State Update"
-def trigger_release_job(job_name, job_type, mxnet_variants) {
+def trigger_release_job(cd_release_job, job_name, job_type, mxnet_variants) {
Review comment:
CD_RELEASE_JOB_NAME is actually a parameter of the CD pipeline, so this is how it's supposed to be used. It is also set as a global env variable, which can potentially cause some issues.
For reference, it is addressed in master by this PR https://github.com/apache/incubator-mxnet/pull/17775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #19774: differentiate nightly docker image tags
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#issuecomment-786475781
@leezu @szha We have changed docker push target to a public ecr repo in master with this PR https://github.com/apache/incubator-mxnet/pull/19772 . Will backport it to v1.x too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19774: differentiate nightly docker image tags
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#issuecomment-765012357
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, website, centos-cpu, edge, unix-gpu, sanity, windows-cpu, unix-cpu, miscellaneous, centos-gpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #19774: [v1.x] Fix nightly CD for python docker image releases
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org