You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Nils Breunese (JIRA)" <ji...@apache.org> on 2012/10/19 14:32:12 UTC
[jira] [Created] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Nils Breunese created COUCHDB-1569:
--------------------------------------
Summary: Low diskspace warning for compaction should be logged at error level
Key: COUCHDB-1569
URL: https://issues.apache.org/jira/browse/COUCHDB-1569
Project: CouchDB
Issue Type: Improvement
Components: Database Core
Affects Versions: 1.2
Reporter: Nils Breunese
Priority: Trivial
In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Robert Newson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481346#comment-13481346 ]
Robert Newson commented on COUCHDB-1569:
----------------------------------------
While I don't think it's sensible or appropriate to expect to only monitor couch.log for system-wide issues like running out of disk space, logging this at error seems reasonable to me. I'll note that writing an error message to disk to tell you you're out of disk space has an obvious limitation.
Short version: yes, long version: you should be monitoring your system's resources with tools dedicated to that purpose (zenoss and the like).
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Russell Branca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell Branca updated COUCHDB-1569:
------------------------------------
Attachment: patch.txt
Here's a quick patch that basically does s/LOG_INFO/LOG_ERROR/ in couch_compaction_daemon:maybe_compact_view and couch_compaction_daemon:maybe_compact_db.
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
> Attachments: patch.txt
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Nils Breunese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481364#comment-13481364 ]
Nils Breunese commented on COUCHDB-1569:
----------------------------------------
We are in fact monitoring disk space with dedicated monitoring tools, but CouchDB apparently required at least two times the current data_size for compaction and that can be a high number for large databases which could be compacted just fine with less free diskspace available.
Anyway, we're just suspecting this is the threshold we're hitting in production, since the message is currently logged at info level and the instance is only logging at error level.
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Dave Cottlehuber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Cottlehuber updated COUCHDB-1569:
--------------------------------------
Fix Version/s: 1.3
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Robert Newson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484483#comment-13484483 ]
Robert Newson commented on COUCHDB-1569:
----------------------------------------
I've been pondering this on and off today. There are other conditions in the compaction daemon that might warrant ERROR level, like when it cancels a compaction because the time period it's allowed to run is has expired. Manually started compactions that would consume all remaining disk space will *not* log at ERROR if you start them either.
So, on reflection, I think this is really an INFO level thing after all (if only because we can't make it ERROR level with any consistency).
What's truly missing is the ability to change log levels by module. i.e, I'd like to see INFO level from couch_compaction_daemon but not from couch_httpd.
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
> Attachments: patch.txt, patch_updated.txt
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Russell Branca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell Branca updated COUCHDB-1569:
------------------------------------
Attachment: patch_updated.txt
Updated patch to fix accidental switching of compaction timeout to LOG_ERROR, rather than just both insufficient space messages.
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
> Attachments: patch.txt, patch_updated.txt
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Russell Branca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Russell Branca updated COUCHDB-1569:
------------------------------------
Comment: was deleted
(was: Here's a quick patch that basically does s/LOG_INFO/LOG_ERROR/ in couch_compaction_daemon:maybe_compact_view and couch_compaction_daemon:maybe_compact_db.)
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
> Attachments: patch.txt
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Russell Branca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484041#comment-13484041 ]
Russell Branca commented on COUCHDB-1569:
-----------------------------------------
Here's a quick patch that basically does s/LOG_INFO/LOG_ERROR/ in couch_compaction_daemon:maybe_compact_view and couch_compaction_daemon:maybe_compact_db.
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
> Attachments: patch.txt
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COUCHDB-1569) Low diskspace warning for
compaction should be logged at error level
Posted by "Dave Cottlehuber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Cottlehuber updated COUCHDB-1569:
--------------------------------------
Skill Level: New Contributors Level (Easy)
> Low diskspace warning for compaction should be logged at error level
> --------------------------------------------------------------------
>
> Key: COUCHDB-1569
> URL: https://issues.apache.org/jira/browse/COUCHDB-1569
> Project: CouchDB
> Issue Type: Improvement
> Components: Database Core
> Affects Versions: 1.2
> Reporter: Nils Breunese
> Priority: Trivial
> Fix For: 1.3
>
>
> In production we're running CouchDB at log level 'error', because running at 'info' is too verbose for production. We suspect automatic compaction might not be running due to low diskspace.
> http://wiki.apache.org/couchdb/Compaction#Automatic_Compaction says: "When there's not enough free disk space to compact a particular database or view index, a warning message is logged." But there is no warning log level in CouchDB as far as I know and the can_db_compact function in src/couchdb/couch_compaction_daemon.erl seems to log the message about diskspace being too low at info level. Could this be changed to error level?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira