You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/23 02:23:53 UTC
[kudu-CR](branch-1.2.x) KUDU-1812. Fix printed default of redaction flag for tools
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5575
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
......................................................................
KUDU-1812. Fix printed default of redaction flag for tools
A previous commit made the default redaction mode for tools get set
after parsing command line options. This means that "--help" would be
not have the correct default displayed.
This changes to using the appropriate gflags API to change the default
programatically.
Change-Id: I5f2535302122c8dc637c67cced88e77a47e62f15
Reviewed-on: http://gerrit.cloudera.org:8080/5574
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 9efb2f8640b8135a935fb3497282f48a3c13bd3a)
---
M src/kudu/tools/tool_main.cc
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/5575/1
--
To view, visit http://gerrit.cloudera.org:8080/5575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f2535302122c8dc637c67cced88e77a47e62f15
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1812. Fix printed default of redaction flag for tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2535302122c8dc637c67cced88e77a47e62f15
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1812. Fix printed default of redaction flag for tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
......................................................................
KUDU-1812. Fix printed default of redaction flag for tools
A previous commit made the default redaction mode for tools get set
after parsing command line options. This means that "--help" would be
not have the correct default displayed.
This changes to using the appropriate gflags API to change the default
programatically.
Change-Id: I5f2535302122c8dc637c67cced88e77a47e62f15
Reviewed-on: http://gerrit.cloudera.org:8080/5574
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 9efb2f8640b8135a935fb3497282f48a3c13bd3a)
Reviewed-on: http://gerrit.cloudera.org:8080/5575
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/tools/tool_main.cc
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f2535302122c8dc637c67cced88e77a47e62f15
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>