You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/03/04 02:40:23 UTC
[PR] GH-40331: [C++][CMake] Add missing glog::glog dependency to arrow_util [arrow]
kou opened a new pull request, #40332:
URL: https://github.com/apache/arrow/pull/40332
### Rationale for this change
`cpp/src/arrow/util/logging.cc` may use glog. So `arrow_util` OBJECT target(s) must depend on `glog::glog`.
### What changes are included in this PR?
Add missing `glog::glog` dependency to `${ARROW_UTIL_TARGETS}`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40331: [C++][CMake] Add missing glog::glog dependency to arrow_util [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40332:
URL: https://github.com/apache/arrow/pull/40332#issuecomment-1975553742
:warning: GitHub issue #40331 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40331: [C++][CMake] Add missing glog::glog dependency to arrow_util [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40332:
URL: https://github.com/apache/arrow/pull/40332#issuecomment-1976635463
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 70bb0fbb17c8e3343f227d0e11a0f19eaa3af92f.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/22248513863) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40331: [C++][CMake] Add missing glog::glog dependency to arrow_util [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #40332:
URL: https://github.com/apache/arrow/pull/40332#issuecomment-1975975846
+1 (non-binding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40331: [C++][CMake] Add missing glog::glog dependency to arrow_util [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #40332:
URL: https://github.com/apache/arrow/pull/40332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org