You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by dgkimura <gi...@git.apache.org> on 2017/03/14 15:18:32 UTC
[GitHub] geode-native pull request #54: GEODE-2657: Execute Region Function sends inc...
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/54
GEODE-2657: Execute Region Function sends incorrect message format
`TcrMessageExecuteRegionFunction` is missing a call to set `m_hasResults`. This causes the message response to be parsed synchronously and not asynchronously chunked. The synchronous parser does not support this message type and it barfs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dgkimura/geode-native develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 9ee4511225c912ee4daa631e1e4ebd35d51d86ae
Author: David Kimura <dk...@pivotal.io>
Date: 2017-03-14T15:14:58Z
GEODE-2657: Execute Region Function sends incorrect message format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #54: GEODE-2657: Execute Region Function sends inc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...
Posted by dgkimura <gi...@git.apache.org>.
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/54
@echobravopapa We're only human.
Our unittest didn't catch it originally because the output that's written to DataOutput in the constructor is the same with/without this variable set. It's likely when the message is sent that client checks this variable and performs some magic. I'm guessing our integration-tests that cover this aren't running. Else we might have had a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
This will get closed when pull #63 is committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura I would suggest getting a few of those integration tests updated to test this. They were marked flaky a long time ago when the tests ran through several iterations with different configurations. Now that we don't do that anymore it should be easy to stabilize the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura I will pull this and work on some of the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura It will give the CI something to chew on to prove that this message actually works with the server now. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #54: GEODE-2657: Execute Region Function sends incorrect ...
Posted by dgkimura <gi...@git.apache.org>.
Github user dgkimura commented on the issue:
https://github.com/apache/geode-native/pull/54
@pivotal-jbarrett Okay. Fair enough. That's going to add some cycles to this pull-request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---