[GitHub] [pulsar] sijie commented on a change in pull request #4079: PIP-34 Key_Shared subscription core implementation.

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #4079: PIP-34 Key_Shared subscription core implementation.
URL: https://github.com/apache/pulsar/pull/4079#discussion_r276888726
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -124,8 +125,9 @@ message SingleMessageMetadata {
 	// the timestamp that this event occurs. it is typically set by applications.
 	// if this field is omitted, `publish_time` can be used for the purpose of `event_time`.
 	optional uint64 event_time = 5 [default = 0];
-
-        optional bool partition_key_b64_encoded = 6 [ default = false ];
+    optional bool partition_key_b64_encoded = 6 [ default = false ];
+    // Specific a key to overwrite the message key which used for ordering dispatch in Key_Shared mode.
+    optional string ordering_key = 7;
 
 Review comment:
   I would prefer using `bytes` for ordering_key. it is a more nature behavior rather using a string because string requires taking care of encoding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services