You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "fresh-borzoni (via GitHub)" <gi...@apache.org> on 2026/04/10 12:42:08 UTC
[PR] chore: fix docs for RustFS AssumeRole [fluss]
fresh-borzoni opened a new pull request, #3058:
URL: https://github.com/apache/fluss/pull/3058
PR fixes the RustFS STS workaround introduced in #2660. That PR disabled KV snapshots (kv.snapshot.interval: 0s) because RustFS doesn't support GetSessionToken. Now that #2989 added AssumeRole support, we can re-enable snapshots by configuring the AssumeRole STS settings instead.
Also adds S3 filesystem documentation for S3-compatible storage and AssumeRole configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: fix docs for RustFS AssumeRole [fluss]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3058:
URL: https://github.com/apache/fluss/pull/3058#discussion_r3064354671
##########
website/docs/quickstart/lakehouse.md:
##########
@@ -110,7 +110,10 @@ services:
s3.endpoint: http://rustfs:9000
s3.access-key: rustfsadmin
s3.secret-key: rustfsadmin
+ s3.region: us-east-1
s3.path.style.access: true
+ s3.assumed.role.arn: arn:aws:iam::0:role/rustfsadmin
+ s3.assumed.role.sts.endpoint: http://rustfs:9000
Review Comment:
In this quickstart snippet, the key is written as `s3.path.style.access`, but other docs (including the S3 filesystem doc) use `s3.path-style-access`. Consider standardizing on a single spelling (preferably `s3.path-style-access`) to avoid confusing users.
Also, `arn:aws:iam::0:role/...` is not a valid AWS role ARN (account IDs are 12 digits). Using a placeholder like `<your-role-arn>` (or a realistic example) would make the docs less error-prone.
##########
website/docs/quickstart/flink.md:
##########
@@ -92,7 +92,10 @@ services:
s3.endpoint: http://rustfs:9000
s3.access-key: rustfsadmin
s3.secret-key: rustfsadmin
+ s3.region: us-east-1
s3.path-style-access: true
+ s3.assumed.role.arn: arn:aws:iam::0:role/rustfsadmin
+ s3.assumed.role.sts.endpoint: http://rustfs:9000
Review Comment:
The example `s3.assumed.role.arn: arn:aws:iam::0:role/...` uses `0` as the AWS account id, which is not a valid ARN format. Consider using `<your-role-arn>` (as in the S3 filesystem doc) or a realistic 12-digit account id to avoid copy/paste failures.
##########
website/docs/quickstart/flink.md:
##########
@@ -108,8 +111,10 @@ services:
s3.endpoint: http://rustfs:9000
s3.access-key: rustfsadmin
s3.secret-key: rustfsadmin
+ s3.region: us-east-1
s3.path-style-access: true
- kv.snapshot.interval: 0s
+ s3.assumed.role.arn: arn:aws:iam::0:role/rustfsadmin
+ s3.assumed.role.sts.endpoint: http://rustfs:9000
Review Comment:
Same as above: `arn:aws:iam::0:role/...` is not a valid AWS role ARN (account IDs are 12 digits). Using a placeholder like `<your-role-arn>` would make the quickstart safer to copy/paste.
##########
website/docs/quickstart/lakehouse.md:
##########
@@ -327,7 +332,10 @@ services:
s3.endpoint: http://rustfs:9000
s3.access-key: rustfsadmin
s3.secret-key: rustfsadmin
+ s3.region: us-east-1
s3.path.style.access: true
+ s3.assumed.role.arn: arn:aws:iam::0:role/rustfsadmin
Review Comment:
For consistency with the S3 filesystem docs and other quickstarts, consider using `s3.path-style-access` here instead of `s3.path.style.access`.
Also consider replacing `arn:aws:iam::0:role/...` with `<your-role-arn>` (or a realistic example), since `0` is not a valid AWS account ID.
```suggestion
s3.path-style-access: true
s3.assumed.role.arn: <your-role-arn>
```
##########
website/docs/quickstart/lakehouse.md:
##########
@@ -356,12 +364,14 @@ services:
zookeeper.address: zookeeper:2181
bind.listeners: FLUSS://tablet-server:9123
data.dir: /tmp/fluss/data
- kv.snapshot.interval: 0s
remote.data.dir: s3://fluss/remote-data
s3.endpoint: http://rustfs:9000
s3.access-key: rustfsadmin
s3.secret-key: rustfsadmin
+ s3.region: us-east-1
s3.path.style.access: true
+ s3.assumed.role.arn: arn:aws:iam::0:role/rustfsadmin
Review Comment:
This snippet still uses `s3.path.style.access`; other docs use `s3.path-style-access`. Aligning these would reduce user confusion.
The example `s3.assumed.role.arn: arn:aws:iam::0:role/...` is not a valid AWS ARN; consider using `<your-role-arn>` or a realistic account ID.
```suggestion
s3.path-style-access: true
s3.assumed.role.arn: <your-role-arn>
```
##########
website/docs/quickstart/lakehouse.md:
##########
@@ -135,8 +138,10 @@ services:
s3.endpoint: http://rustfs:9000
s3.access-key: rustfsadmin
s3.secret-key: rustfsadmin
+ s3.region: us-east-1
s3.path.style.access: true
- kv.snapshot.interval: 0s
+ s3.assumed.role.arn: arn:aws:iam::0:role/rustfsadmin
+ s3.assumed.role.sts.endpoint: http://rustfs:9000
Review Comment:
This snippet uses `s3.path.style.access`, while other docs use `s3.path-style-access`. Standardizing the key spelling across docs would help prevent misconfiguration.
The example role ARN `arn:aws:iam::0:role/...` is also not a valid AWS ARN; consider switching to `<your-role-arn>` (as in the S3 doc) or a realistic 12-digit account ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: fix docs for RustFS AssumeRole [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #3058:
URL: https://github.com/apache/fluss/pull/3058#issuecomment-4223834279
@luoyuxia @leekeiabstraction PTAL 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: fix docs for RustFS AssumeRole [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #3058:
URL: https://github.com/apache/fluss/pull/3058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: fix docs for RustFS AssumeRole [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #3058:
URL: https://github.com/apache/fluss/pull/3058#issuecomment-4224182166
@luoyuxia Ty, addressed Copilot comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: fix docs for RustFS AssumeRole [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #3058:
URL: https://github.com/apache/fluss/pull/3058#issuecomment-4235648287
@luoyuxia Ty, here we go - https://github.com/apache/fluss/pull/3065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org