You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/09/13 15:30:13 UTC
[GitHub] [hbase] wchevreuil commented on a change in pull request #3665: HBASE-26248 Should find a suitable way to let users specify the store…
wchevreuil commented on a change in pull request #3665:
URL: https://github.com/apache/hbase/pull/3665#discussion_r707440847
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -33,22 +36,82 @@
/**
* Factory method for creating store file tracker.
+ * <p/>
+ * The current implementations are:
+ * <ul>
+ * <li><em>default</em>: DefaultStoreFileTracker, see {@link DefaultStoreFileTracker}.</li>
+ * <li><em>file</em>:FileBasedStoreFileTracker, see {@link FileBasedStoreFileTracker}.</li>
+ * <li><em>migration</em>:MigrationStoreFileTracker, see {@link MigrationStoreFileTracker}.</li>
+ * </ul>
+ * @see DefaultStoreFileTracker
+ * @see FileBasedStoreFileTracker
+ * @see MigrationStoreFileTracker
*/
-@InterfaceAudience.Private public final class StoreFileTrackerFactory {
- public static final String TRACK_IMPL = "hbase.store.file-tracker.impl";
+@InterfaceAudience.Private
+public final class StoreFileTrackerFactory {
+
private static final Logger LOG = LoggerFactory.getLogger(StoreFileTrackerFactory.class);
- public static Class<? extends StoreFileTracker> getStoreFileTrackerImpl(Configuration conf) {
- return conf.getClass(TRACK_IMPL, DefaultStoreFileTracker.class, StoreFileTracker.class);
+ public static final String TRACKER_IMPL = "hbase.store.file-tracker.impl";
+
+ /**
+ * Maps between configuration names for trackers and implementation classes.
+ */
+ public enum Trackers {
+ DEFAULT(DefaultStoreFileTracker.class), FILE(FileBasedStoreFileTracker.class),
+ MIGRATION(MigrationStoreFileTracker.class);
+
+ final Class<? extends StoreFileTracker> clazz;
+
+ private Trackers(Class<? extends StoreFileTracker> clazz) {
+ this.clazz = clazz;
+ }
+ }
+
+ private static final Map<Class<? extends StoreFileTracker>, Trackers> CLASS_TO_ENUM = reverse();
+
+ private static Map<Class<? extends StoreFileTracker>, Trackers> reverse() {
+ Map<Class<? extends StoreFileTracker>, Trackers> map = new HashMap<>();
+ for (Trackers tracker : Trackers.values()) {
+ map.put(tracker.clazz, tracker);
+ }
+ return Collections.unmodifiableMap(map);
+ }
+
+ private StoreFileTrackerFactory() {
+ }
+
+ public static String getStoreFileTrackerName(Configuration conf) {
+ return conf.get(TRACKER_IMPL, Trackers.DEFAULT.name());
+ }
+
+ static String getStoreFileTrackerName(Class<? extends StoreFileTracker> clazz) {
+ Trackers name = CLASS_TO_ENUM.get(clazz);
+ return name != null ? name.name() : clazz.getName();
+ }
+
+ private static Class<? extends StoreFileTracker> getTrackerClass(Configuration conf,
+ String configName) {
Review comment:
nit: non used param.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -64,15 +127,30 @@ public static Configuration mergeConfigurations(Configuration global, TableDescr
.addStringMap(family.getConfiguration()).addBytesMap(family.getValues());
}
- static StoreFileTrackerBase create(Configuration conf, String configName,
+ /**
+ * Create store file tracker to be used as source or destination for
+ * {@link MigrationStoreFileTracker}.
+ */
+ static StoreFileTrackerBase createForMigration(Configuration conf, String configName,
boolean isPrimaryReplica, StoreContext ctx) {
- String className =
+ String trackerName =
Preconditions.checkNotNull(conf.get(configName), "config %s is not set", configName);
Class<? extends StoreFileTrackerBase> tracker;
try {
- tracker = Class.forName(className).asSubclass(StoreFileTrackerBase.class);
- } catch (ClassNotFoundException e) {
- throw new RuntimeException(e);
+ tracker =
+ Trackers.valueOf(trackerName.toUpperCase()).clazz.asSubclass(StoreFileTrackerBase.class);
+ } catch (IllegalArgumentException e) {
+ // Fall back to them specifying a class name
+ try {
+ tracker = Class.forName(trackerName).asSubclass(StoreFileTrackerBase.class);
+ } catch (ClassNotFoundException cnfe) {
+ throw new RuntimeException(cnfe);
+ }
Review comment:
Is it worth having this same fallback on the usual create method as well?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -33,22 +36,82 @@
/**
* Factory method for creating store file tracker.
+ * <p/>
+ * The current implementations are:
+ * <ul>
+ * <li><em>default</em>: DefaultStoreFileTracker, see {@link DefaultStoreFileTracker}.</li>
+ * <li><em>file</em>:FileBasedStoreFileTracker, see {@link FileBasedStoreFileTracker}.</li>
+ * <li><em>migration</em>:MigrationStoreFileTracker, see {@link MigrationStoreFileTracker}.</li>
+ * </ul>
+ * @see DefaultStoreFileTracker
+ * @see FileBasedStoreFileTracker
+ * @see MigrationStoreFileTracker
*/
-@InterfaceAudience.Private public final class StoreFileTrackerFactory {
- public static final String TRACK_IMPL = "hbase.store.file-tracker.impl";
+@InterfaceAudience.Private
+public final class StoreFileTrackerFactory {
+
private static final Logger LOG = LoggerFactory.getLogger(StoreFileTrackerFactory.class);
- public static Class<? extends StoreFileTracker> getStoreFileTrackerImpl(Configuration conf) {
- return conf.getClass(TRACK_IMPL, DefaultStoreFileTracker.class, StoreFileTracker.class);
+ public static final String TRACKER_IMPL = "hbase.store.file-tracker.impl";
+
+ /**
+ * Maps between configuration names for trackers and implementation classes.
+ */
+ public enum Trackers {
+ DEFAULT(DefaultStoreFileTracker.class), FILE(FileBasedStoreFileTracker.class),
+ MIGRATION(MigrationStoreFileTracker.class);
+
+ final Class<? extends StoreFileTracker> clazz;
+
+ private Trackers(Class<? extends StoreFileTracker> clazz) {
Review comment:
nit: redundant modifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org