[GitHub] [drill] ihuzenko commented on issue #1649: DRILL-6970: Issue with LogRegex format plugin where drillbuf was overflowing

[GitBox <gi...@apache.org>]

ihuzenko commented on issue #1649: DRILL-6970: Issue with LogRegex format plugin where drillbuf was overflowing 
URL: https://github.com/apache/drill/pull/1649#issuecomment-474511694
 
 
   @jcmcote I'd like to suggest redesign the **LogRecordReader** a little bit. The main idea is to extract all try-catches from _**load(int rowIndex, String value)**_ methods of each concrete **ColumnDefn** implementation and make one unified ```try-cacth``` which will wrap whole loop used for reading and handling of each line in log file for the reader (the while loop inside ```next()```). Such approach will reduce boilerplate code and expected that it'll work faster, because try-catch will be initiated once per row batch instead of each column of each line (row). Note that it's not requirement for this pull request, but rather suggestion for future improvement. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services