Re: Review Request 68573: SENTRY-2311 Intellij is broken by shaded jars

[Steve Moist via Review Board <no...@reviews.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68573/
-----------------------------------------------------------

(Updated Sept. 7, 2018, 4:52 p.m.)


Review request for sentry.


Bugs: SENTRY-2311
    https://issues.apache.org/jira/browse/SENTRY-2311


Repository: sentry


Description
-------

Removed the shading from the individual projects and put it at the end.  This avoids Intellij issues and allows us to still shade the offending jars.  It then excludes the dependencies and adds them at the end.


Diffs (updated)
-----

  pom.xml d5f9dc6f5 
  sentry-dist/pom.xml 6291e4f1c 
  sentry-dist/src/main/assembly/bin.xml fc012c671 
  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java 0d39300fe 
  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java 2b1618134 
  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java b9405ccd2 
  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java f3a2d5028 
  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 5e2d5c5ee 
  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHdfsMetricsUtil.java f299825ba 
  sentry-provider/sentry-provider-db/pom.xml 9f89ca30a 
  sentry-service/sentry-service-server/pom.xml 8315358fc 
  sentry-thirdparty/pom.xml PRE-CREATION 
  sentry-thirdparty/sentry-shaded/pom.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/68573/diff/2/

Changes: https://reviews.apache.org/r/68573/diff/1-2/


Testing
-------

Unpacked the provided jars and ran it in a cluster.


Thanks,

Steve Moist