You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/10 07:47:27 UTC
Re: Review Request 39968: Enable endpoint include nested paths
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39968/#review118596
-----------------------------------------------------------
3rdparty/libprocess/src/help.cpp (line 122)
<https://reviews.apache.org/r/39968/#comment179876>
I think could use
```
strings::split(strings::trim(request.url.path, strings::ANY, "/"), "/", 3);
```
to handle this part.
`tokens[1]` is always the id while `tokens[2]` is the name when `tokens.size() >= 3`.
- haosdent huang
On Nov. 5, 2015, 7:25 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39968/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:25 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3833
> https://issues.apache.org/jira/browse/MESOS-3833
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enable endpoint include nested paths
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/help.cpp 3f82c0fb41a0d9388d88dbecc9289d705c2a343a
>
> Diff: https://reviews.apache.org/r/39968/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39968: Enabled http endpoint include nested paths.
Posted by Guangya Liu <gy...@gmail.com>.
> On 二月 10, 2016, 6:47 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/src/help.cpp, line 124
> > <https://reviews.apache.org/r/39968/diff/1/?file=1116594#file1116594line124>
> >
> > I think could use
> > ```
> > strings::split(strings::trim(request.url.path, strings::ANY, "/"), "/", 3);
> > ```
> > to handle this part.
> > `tokens[1]` is always the id while `tokens[2]` is the name when `tokens.size() >= 3`.
Thanks haosdent, it does helps!
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39968/#review118596
-----------------------------------------------------------
On 二月 10, 2016, 1:37 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39968/
> -----------------------------------------------------------
>
> (Updated 二月 10, 2016, 1:37 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3833
> https://issues.apache.org/jira/browse/MESOS-3833
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled http endpoint include nested paths.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/help.cpp be3f7b74d92bd0626d111fd4ddd4cacd74e36e68
>
> Diff: https://reviews.apache.org/r/39968/diff/
>
>
> Testing
> -------
>
> LiuGuangyas-MacBook-Pro:~ gyliu$ curl "http://192.168.0.100:5050/help/master/api/v1/scheduler"
> ### USAGE ###
> > /master/api/v1/scheduler
>
> ### TL;DR; ###
> Endpoint for schedulers to make Calls against the master.
>
> ### DESCRIPTION ###
> Returns 202 Accepted iff the request is accepted.
>
>
> Thanks,
>
> Guangya Liu
>
>