You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "uds5501 (via GitHub)" <gi...@apache.org> on 2023/06/07 11:17:22 UTC
[GitHub] [incubator-kvrocks] uds5501 opened a new pull request, #1488: Feat: Block instance replication of itself and it's own replicas
uds5501 opened a new pull request, #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488
WIP: A patch to block an instance from replicating itself and it's own replicas
Fixes: #1484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488#issuecomment-1581779704
Thanks @uds5501, you need to fix the clang-tidy error: https://github.com/apache/incubator-kvrocks/actions/runs/5199313230/jobs/9376587287?pr=1488#step:8:1166 to pass the CI. And can you add some Go tests to make sure it works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] uds5501 commented on pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "uds5501 (via GitHub)" <gi...@apache.org>.
uds5501 commented on PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488#issuecomment-1585812626
@git-hulk , added integration test and clang-tidy error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488#discussion_r1225746317
##########
src/server/server.cc:
##########
@@ -1751,3 +1751,16 @@ void Server::ResetWatchedKeys(redis::Connection *conn) {
watched_key_size_ = watched_key_map_.size();
}
}
+
+std::list<std::pair<std::string, uint32_t>> Server::GetSlaveHostAndPort() {
+ std::list<std::pair<std::string, uint32_t>> result;
+ slave_threads_mu_.lock();
+ for (const auto &slave : slave_threads_) {
+ if (slave->IsStopped()) continue;
+ std::pair<std::string, int> host_port_pair = {slave->GetConn()->GetAnnounceIP(),
+ slave->GetConn()->GetListeningPort()};
+ result.emplace_back(host_port_pair);
+ }
+ slave_threads_mu_.unlock();
+ return result;
+}
Review Comment:
```suggestion
}
```
Newline in the end of the file is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488#issuecomment-1586025894
> @git-hulk , added integration test and clang-tidy error
Thanks for your efforts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488#issuecomment-1587107979
@uds5501 Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1488: Feat: Block instance replication of itself and it's own replicas
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1488:
URL: https://github.com/apache/incubator-kvrocks/pull/1488#issuecomment-1587106103
Thanks all, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org