You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/03/29 16:20:01 UTC
[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #809: LOG4J2-3452: Fix race condition in FileUtils.mkdir()
ppkarwasz commented on a change in pull request #809:
URL: https://github.com/apache/logging-log4j2/pull/809#discussion_r837669556
##########
File path: log4j-core/src/test/java/org/apache/logging/log4j/core/util/FileUtilsTest.java
##########
@@ -78,4 +86,56 @@ public void testFileFromUriWithSpacesAndPlusCharactersInName() throws Exception
assertTrue(file.exists(), "file exists");
}
+ @Nested
+ class TestMkdir {
+ final String path = "src/test/resources/test-dir";
Review comment:
I wouldn't use the source directory for tests. Use rather a `@TempDir` created by Junit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org