You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/26 15:19:20 UTC
[GitHub] [incubator-druid] leventov opened a new issue #8168: Optimize
memory usage by AtomicUpdateGroup
leventov opened a new issue #8168: Optimize memory usage by AtomicUpdateGroup
URL: https://github.com/apache/incubator-druid/issues/8168
There is a comment inside `AtomicUpdateGroup` talking about the importance of memory usage by this class.
The Javadoc comment for the class also says that this object usually contains just one entry.
If so, the easy optimization is to initialize `chunks = new ArrayList<>(1)` - with the capacity of 1.
A more advanced version would be for `OvershadowableManager` to store `Short2ObjectSortedMap<Object>` maps, where the values may be either `PartitionChunk` directly (if there is one chunk in a group), or `AtomicUpdateGroup` (if there are 2+ chunks in a group). It would complicate ` OvershadowableManager`'s code but would allow avoiding a level of indirection and creation of a lot of `AtomicUpdateGroup`, `ArrayList`, and `Object[]` objects.
FYI @jihoonson
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org