[GitHub] [iotdb] mychaow commented on a diff in pull request #5994: [IOTDB-2919] Refactor delete storage group

[GitBox <gi...@apache.org>]

mychaow commented on code in PR #5994:
URL: https://github.com/apache/iotdb/pull/5994#discussion_r879998555


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PartitionManager.java:
##########
@@ -65,12 +72,21 @@ public class PartitionManager {
 
   private SeriesPartitionExecutor executor;
 
+  private final ScheduledExecutorService regionCleaner;
+
   public PartitionManager(Manager configManager, PartitionInfo partitionInfo) {
     this.configManager = configManager;
     this.partitionInfo = partitionInfo;
+    this.regionCleaner =
+        IoTDBThreadPoolFactory.newSingleThreadScheduledExecutor("IoTDB-StorageGroup-Cleaner");
+    regionCleaner.scheduleAtFixedRate(this::clearDeletedStorageGroup, 10, 5, TimeUnit.SECONDS);

Review Comment:
   maybe create magic number, and the period maybe larger? like 60s，or 300s



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org