You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/02/08 07:06:03 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39938: [SPARK-42267][CONNECT][PYTHON] `DataFrame.join` should standardize the JoinType string
zhengruifeng opened a new pull request, #39938:
URL: https://github.com/apache/spark/pull/39938
### What changes were proposed in this pull request?
standardize the JoinType string
be consistent with PySpark https://github.com/apache/spark/blob/05c0fa573881b49d8ead9a5e16071190e5841e1b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala#L25
### Why are the changes needed?
```
>>> df = spark.range(1)
>>> df2 = spark.range(2)
>>> df.join(df2, how="left_outer")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/xinrong.meng/spark/python/pyspark/sql/connect/dataframe.py", line 438, in join
plan.Join(left=self._plan, right=other._plan, on=on, how=how),
File "/Users/xinrong.meng/spark/python/pyspark/sql/connect/plan.py", line 730, in _init_
raise NotImplementedError(
NotImplementedError:
Unsupported join type: left_outer. Supported join types include:
"inner", "outer", "full", "fullouter", "full_outer",
"leftouter", "left", "left_outer", "rightouter",
"right", "right_outer", "leftsemi", "left_semi",
"semi", "leftanti", "left_anti", "anti", "cross",
```
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
updated UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39938: [SPARK-42267][CONNECT][PYTHON] `DataFrame.join` should standardize the JoinType string
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #39938:
URL: https://github.com/apache/spark/pull/39938#issuecomment-1422110333
cc @xinrong-meng @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39938: [SPARK-42267][CONNECT][PYTHON] `DataFrame.join` should standardize the JoinType string
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39938:
URL: https://github.com/apache/spark/pull/39938#issuecomment-1422216424
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39938: [SPARK-42267][CONNECT][PYTHON] `DataFrame.join` should standardize the JoinType string
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #39938: [SPARK-42267][CONNECT][PYTHON] `DataFrame.join` should standardize the JoinType string
URL: https://github.com/apache/spark/pull/39938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org