You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/03/13 20:08:33 UTC

Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19195/
-----------------------------------------------------------

(Updated March 13, 2014, 7:08 p.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Summary (updated)
-----------------

Automation of CCP Objects Verification after external changes made to the original setup


Repository: cloudstack-git


Description
-------

Purpose of this code:

Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product.

The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time.

The following are the scenarios that the code format can be used for:
1.Upgrade Validity Verification
     a.	CCP Upgrade
     b.	Hypervisors Upgrade
     c.	External Devices Upgrade
     d.	System VM Template Changes.
2.Patch Validity Verification

Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. 

How to use the code:

*Kindly make the corresponding substitutions in the commands listed below.

Execute:
 nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade

After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes.

Execute:
nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade


Diffs
-----

  test/integration/component/test_minimal_ug_check.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19195/diff/


Testing
-------

PreUpgrade Output:

Test case no : Enable VPN for Public IP Address on the VPC ... ok    <-- Will fix the description in the next patch

----------------------------------------------------------------------
Ran 1 test in 1683.515s

OK

Post Upgrade Output:

Test case no : Remote a VPN User ... ok  <-- Will fix the description in the next patch

----------------------------------------------------------------------
Ran 1 test in 1269.134s

OK


Thanks,

Chandan Purushothama


Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup

Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19195/#review78980
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.

- Sebastien Goasguen


On March 14, 2014, 12:33 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19195/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 12:33 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Purpose of this code:
> 
> Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product.
> 
> The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time.
> 
> The following are the scenarios that the code format can be used for:
> 1.Upgrade Validity Verification
>      a.	CCP Upgrade
>      b.	Hypervisors Upgrade
>      c.	External Devices Upgrade
>      d.	System VM Template Changes.
> 2.Patch Validity Verification
> 
> Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. 
> 
> How to use the code:
> 
> *Kindly make the corresponding substitutions in the commands listed below.
> 
> Execute:
>  nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade
> 
> After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes.
> 
> Execute:
> nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_minimal_ug_check.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19195/diff/
> 
> 
> Testing
> -------
> 
> PreUpgrade Output:
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... ok    <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1683.515s
> 
> OK
> 
> Post Upgrade Output:
> 
> Test case no : Remote a VPN User ... ok  <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1269.134s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup

Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19195/#review64021
-----------------------------------------------------------


If this is still valid, can you send a new patch for master or close it?

- Rohit Yadav


On March 14, 2014, 12:33 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19195/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 12:33 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Purpose of this code:
> 
> Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product.
> 
> The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time.
> 
> The following are the scenarios that the code format can be used for:
> 1.Upgrade Validity Verification
>      a.	CCP Upgrade
>      b.	Hypervisors Upgrade
>      c.	External Devices Upgrade
>      d.	System VM Template Changes.
> 2.Patch Validity Verification
> 
> Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. 
> 
> How to use the code:
> 
> *Kindly make the corresponding substitutions in the commands listed below.
> 
> Execute:
>  nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade
> 
> After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes.
> 
> Execute:
> nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_minimal_ug_check.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19195/diff/
> 
> 
> Testing
> -------
> 
> PreUpgrade Output:
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... ok    <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1683.515s
> 
> OK
> 
> Post Upgrade Output:
> 
> Test case no : Remote a VPN User ... ok  <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1269.134s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

> On Feb. 13, 2015, 6:42 a.m., SrikanteswaraRao Talluri wrote:
> > pushed to master 7461297f3e17b431643e7a8c575e799d0e151261

reverted this from master as this is not tested and causing other tests to fail. Please resubmit a fresh patch for master.


- SrikanteswaraRao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19195/#review72329
-----------------------------------------------------------


On March 14, 2014, 12:33 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19195/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 12:33 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Purpose of this code:
> 
> Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product.
> 
> The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time.
> 
> The following are the scenarios that the code format can be used for:
> 1.Upgrade Validity Verification
>      a.	CCP Upgrade
>      b.	Hypervisors Upgrade
>      c.	External Devices Upgrade
>      d.	System VM Template Changes.
> 2.Patch Validity Verification
> 
> Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. 
> 
> How to use the code:
> 
> *Kindly make the corresponding substitutions in the commands listed below.
> 
> Execute:
>  nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade
> 
> After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes.
> 
> Execute:
> nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_minimal_ug_check.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19195/diff/
> 
> 
> Testing
> -------
> 
> PreUpgrade Output:
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... ok    <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1683.515s
> 
> OK
> 
> Post Upgrade Output:
> 
> Test case no : Remote a VPN User ... ok  <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1269.134s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19195/#review72329
-----------------------------------------------------------


pushed to master 7461297f3e17b431643e7a8c575e799d0e151261

- SrikanteswaraRao Talluri


On March 14, 2014, 12:33 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19195/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 12:33 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Purpose of this code:
> 
> Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product.
> 
> The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time.
> 
> The following are the scenarios that the code format can be used for:
> 1.Upgrade Validity Verification
>      a.	CCP Upgrade
>      b.	Hypervisors Upgrade
>      c.	External Devices Upgrade
>      d.	System VM Template Changes.
> 2.Patch Validity Verification
> 
> Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. 
> 
> How to use the code:
> 
> *Kindly make the corresponding substitutions in the commands listed below.
> 
> Execute:
>  nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade
> 
> After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes.
> 
> Execute:
> nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_minimal_ug_check.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19195/diff/
> 
> 
> Testing
> -------
> 
> PreUpgrade Output:
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... ok    <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1683.515s
> 
> OK
> 
> Post Upgrade Output:
> 
> Test case no : Remote a VPN User ... ok  <-- Will fix the description in the next patch
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1269.134s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Re: Review Request 19195: Automation of CCP Objects Verification after external changes made to the original setup

Posted by Chandan Purushothama <Ch...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19195/
-----------------------------------------------------------

(Updated March 14, 2014, 12:33 a.m.)


Review request for cloudstack, Girish Shilamkar, Raja Pullela, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Changes
-------

 Expanded the PostUpgrade Test to Verify the Second VM deployed on a Different Host prior to Upgrade. Make few comment corrections too.


Repository: cloudstack-git


Description
-------

Purpose of this code:

Generate CCP Objects (VMs, Volumes, Snapshots, VPC, etc..) and CCP Use Cases (Networking, Data Content,etc) before an external action on the CCP Setup and verify the integrity of the CCP Objects and the Use Cases after the external action on the CCP Setup. The integrity of the CCP Objects is verified by performing operations that test the Usability of the objects. This validates the intactness of the setup after an external action. The submitted patch covers only few major use cases. It proves that similar code can be added in future to address similar goals in verifying the integrity of CCP objects belonging to different components of the product.

The code format can be followed to verify validity of real time business use cases while any code changes (CCP,hypervisor,external devices code, etc…) happen over a period of time.

The following are the scenarios that the code format can be used for:
1.Upgrade Validity Verification
     a.	CCP Upgrade
     b.	Hypervisors Upgrade
     c.	External Devices Upgrade
     d.	System VM Template Changes.
2.Patch Validity Verification

Code can be used as one of the primary Components to validity Upgrades. It will facilitate the automation of Upgrade Test Verification completely. 

How to use the code:

*Kindly make the corresponding substitutions in the commands listed below.

Execute:
 nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=preupgrade

After Upgrade or any Changes done to the Setup, Verify that the existing CCP objects are not affected due to the external changes.

Execute:
nosetests --with-marvin --marvin-config=$CONFIG $BASEDIR/integration/component/ test_minimal_ug_check.py --load -a tags=postupgrade


Diffs (updated)
-----

  test/integration/component/test_minimal_ug_check.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19195/diff/


Testing
-------

PreUpgrade Output:

Test case no : Enable VPN for Public IP Address on the VPC ... ok    <-- Will fix the description in the next patch

----------------------------------------------------------------------
Ran 1 test in 1683.515s

OK

Post Upgrade Output:

Test case no : Remote a VPN User ... ok  <-- Will fix the description in the next patch

----------------------------------------------------------------------
Ran 1 test in 1269.134s

OK


Thanks,

Chandan Purushothama