[jira] [Commented] (DRILL-303) RecordBatchLoader.load always creates new schema

["Steven Phillips (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829384#comment-13829384 ] 

Steven Phillips commented on DRILL-303:
---------------------------------------

Created reviewboard https://reviews.apache.org/r/15766/


> RecordBatchLoader.load always creates new schema
> ------------------------------------------------
>
>                 Key: DRILL-303
>                 URL: https://issues.apache.org/jira/browse/DRILL-303
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Steven Phillips
>         Attachments: DRILL-303.patch
>
>
> Every single batch coming off the wire is treated as having a new schema, even if it isn't.
> The problem is that oldVectors is Map<MaterializedField,ValueVector>, but we are calling oldFields.remove(fieldDef), where fieldDef is a type FieldDef. Java doesn't do a check in this instance, and this call simply returns null.
> This bug actually masked another problem. If it did not return null, the returned vector is added to container, but it should be added to newVectors. We also don't load the vector with data from the incoming ByteBuf.



--
This message was sent by Atlassian JIRA
(v6.1#6144)