You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "mytang0 (via GitHub)" <gi...@apache.org> on 2023/02/16 07:32:14 UTC
[GitHub] [shardingsphere-elasticjob] mytang0 opened a new pull request, #2182: The lite-core module decouples ZooKeeper
mytang0 opened a new pull request, #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
The elasticjob-lite-core module decouples ZooKeeper, introduce the implementation of the on-demand registration center when using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] mytang0 commented on a diff in pull request #2182: The lite-core module decouples ZooKeeper
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182#discussion_r1136902016
##########
elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/api/registry/JobInstanceRegistry.java:
##########
@@ -17,9 +17,14 @@
package org.apache.shardingsphere.elasticjob.lite.api.registry;
+import java.util.Arrays;
Review Comment:
Caused by reformatting code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a diff in pull request #2182: The lite-core module decouples ZooKeeper
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on code in PR #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182#discussion_r1136686431
##########
elasticjob-lite/elasticjob-lite-core/pom.xml:
##########
@@ -125,5 +121,11 @@
<artifactId>logback-classic</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.shardingsphere.elasticjob</groupId>
+ <artifactId>elasticjob-registry-center-zookeeper-curator</artifactId>
+ <version>${project.parent.version}</version>
+ <scope>test</scope>
Review Comment:
Could we consider setting it `runtime`? Otherwise users need to introduce it sperately.
##########
elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/api/registry/JobInstanceRegistry.java:
##########
@@ -17,9 +17,14 @@
package org.apache.shardingsphere.elasticjob.lite.api.registry;
+import java.util.Arrays;
Review Comment:
There are too many unrelated changes in this PR. Please revert them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2182: The lite-core module decouples ZooKeeper
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182#issuecomment-1432648589
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2182](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aea9c7f) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/bf9bf756c0c8c0a05d48d91e0907f4509a535741?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf9bf75) will **not change** coverage.
> The diff coverage is `81.81%`.
```diff
@@ Coverage Diff @@
## master #2182 +/- ##
=========================================
Coverage 84.61% 84.61%
- Complexity 1916 1917 +1
=========================================
Files 286 287 +1
Lines 6279 6279
Branches 695 692 -3
=========================================
Hits 5313 5313
- Misses 646 648 +2
+ Partials 320 318 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sticjob/lite/api/registry/JobInstanceRegistry.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL3JlZ2lzdHJ5L0pvYkluc3RhbmNlUmVnaXN0cnkuamF2YQ==) | `41.37% <0.00%> (ø)` | |
| [...ite/internal/listener/ListenerNotifierManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvbGlzdGVuZXIvTGlzdGVuZXJOb3RpZmllck1hbmFnZXIuamF2YQ==) | `89.47% <ø> (ø)` | |
| [...ere/elasticjob/lite/internal/util/ThreadUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvdXRpbC9UaHJlYWRVdGlscy5qYXZh) | `70.00% <70.00%> (ø)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `89.70% <100.00%> (+3.80%)` | :arrow_up: |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `91.66% <0.00%> (-4.17%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] mytang0 commented on pull request #2182: The lite-core module decouples ZooKeeper
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on PR #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182#issuecomment-1434878577
Please take a look @TeslaCN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] mytang0 commented on a diff in pull request #2182: The lite-core module decouples ZooKeeper
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182#discussion_r1136900379
##########
elasticjob-lite/elasticjob-lite-core/pom.xml:
##########
@@ -125,5 +121,11 @@
<artifactId>logback-classic</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.shardingsphere.elasticjob</groupId>
+ <artifactId>elasticjob-registry-center-zookeeper-curator</artifactId>
+ <version>${project.parent.version}</version>
+ <scope>test</scope>
Review Comment:
Yes, after decoupling, users are expected to actively introduce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org