You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2017/01/12 09:52:50 UTC
[GitHub] flink pull request #3100: [FLINK-5466] [webfrontend] Set environment to prod...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/3100
[FLINK-5466] [webfrontend] Set environment to production in gulpfile
The default environment was set to `development`, which leads to very large generated JS files. When building the web UI we apparently forgot to set the environment to `production` (build via `gulp production`).
Since this is likely to occur again, I set the default environment to `production` and let users set the environment to `development` manually (via `gulp dev`).
Now:
```
-rw-r--r-- 1 uce staff 42K Jan 12 10:43 index.js
-rw-r--r-- 1 uce staff 931K Jan 12 10:43 vendor.js
```
Before:
```
-rw-r--r-- 1 uce staff 328K Jan 12 10:49 index.js
-rw-r--r-- 1 uce staff 8.4M Jan 12 10:49 vendor.js
```
I would like to merge this to the 1.1 and 1.2 branches as well.
/cc @joerg84
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 5466-prod
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3100
----
commit bd666810aa2df86206b607199139dedb23910b84
Author: Ufuk Celebi <uc...@apache.org>
Date: 2017-01-12T09:46:31Z
[FLINK-5466] [webfrontend] Set environment to production in gulpfile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3100: [FLINK-5466] [webfrontend] Set environment to production ...
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on the issue:
https://github.com/apache/flink/pull/3100
LGTM, thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3100: [FLINK-5466] [webfrontend] Set environment to production ...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3100
+1 to merge and backport. This is a big improvement when accessing the web UI over a slow connection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3100: [FLINK-5466] [webfrontend] Set environment to production ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3100
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3100: [FLINK-5466] [webfrontend] Set environment to prod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---