You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2018/01/02 22:34:50 UTC

[kudu-CR] [java clien] update propagate TS for AUTO FLUSH SYNC flush mode

David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )

Change subject: [java clien] update propagate TS for AUTO_FLUSH_SYNC flush mode
......................................................................


Patch Set 2:

(2 comments)

does the changes made to test make it fail prior to the fix? can you mention that in the commit message?

http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:

http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS2, Line 534:       // Add a callback to update propagated timestamp returned from server.
nit: missing "the"


http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:

http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS2, Line 92: single operations
operation?



-- 
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 02 Jan 2018 22:34:50 +0000
Gerrit-HasComments: Yes