You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/07 19:42:57 UTC
[GitHub] [pulsar] vzhikserg opened a new pull request #6910: [functions] Fix typos in exceptions related to functions
vzhikserg opened a new pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910
### Modifications
Fix typos in exceptions related to functions. The tests were updated as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6910: [functions] Fix typos in exceptions related to functions
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910#issuecomment-625524039
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #6910: [functions] Fix typos in exceptions related to functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910#discussion_r421914746
##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
##########
@@ -35,8 +35,6 @@
import java.lang.reflect.Type;
import java.net.MalformedURLException;
import java.util.*;
Review comment:
@vzhikserg Thanks for the fix. Would you please also help remove this `*` use case? we should avoid `*`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on a change in pull request #6910: [functions] Fix typos in exceptions related to functions
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on a change in pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910#discussion_r421986355
##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
##########
@@ -35,8 +35,6 @@
import java.lang.reflect.Type;
import java.net.MalformedURLException;
import java.util.*;
Review comment:
Sure, it is fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6910: [functions] Fix typos in exceptions related to functions
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910#issuecomment-625764569
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6910: [functions] Fix typos in exceptions related to functions
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910#issuecomment-625783540
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6910: [functions] Fix typos in exceptions related to functions
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6910:
URL: https://github.com/apache/pulsar/pull/6910#issuecomment-625724988
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org