You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2024/07/04 12:14:40 UTC
[PR] [ISSUE #8360] Add more test coverage for MQAdminImpl [rocketmq]
yx9o opened a new pull request, #8361:
URL: https://github.com/apache/rocketmq/pull/8361
Fixes #8360 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8360] Add more test coverage for MQAdminImpl [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8361:
URL: https://github.com/apache/rocketmq/pull/8361#issuecomment-2208881069
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 43.90%. Comparing base [(`77d6633`)](https://app.codecov.io/gh/apache/rocketmq/commit/77d6633e622200ed52feef6fb2adeb12fba8e2c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e8f4f57`)](https://app.codecov.io/gh/apache/rocketmq/commit/e8f4f576450f16dfd7fdbb5422acd0e6ce4f7afb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8361 +/- ##
=============================================
+ Coverage 43.87% 43.90% +0.02%
- Complexity 10646 10649 +3
=============================================
Files 1274 1274
Lines 88939 88939
Branches 11432 11432
=============================================
+ Hits 39024 39049 +25
+ Misses 44991 44932 -59
- Partials 4924 4958 +34
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8361?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8360] Add more test coverage for MQAdminImpl [rocketmq]
Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu merged PR #8361:
URL: https://github.com/apache/rocketmq/pull/8361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8360] Add more test coverage for MQAdminImpl [rocketmq]
Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu commented on PR #8361:
URL: https://github.com/apache/rocketmq/pull/8361#issuecomment-2210352822
Nice job, thanks @yx9o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org