You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/24 01:01:35 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #107: Add changelog for 0.5.0
kezhenxu94 opened a new pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107#discussion_r548338634
##########
File path: .asf.yaml
##########
@@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
Review comment:
> How about non-trivial changes ?
Committers can request reviews from other committers, as we have limited committers in this repo, I'd rather work on trust that we know the changes are non-trivial and need review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] fgksgf commented on a change in pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107#discussion_r548339825
##########
File path: .asf.yaml
##########
@@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
Review comment:
Can those people who are not members (committer/PMC) merge directly when the checks passed ? If they can't I think this change of `.asf.yml` is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107#discussion_r548336881
##########
File path: .asf.yaml
##########
@@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
Review comment:
I'm removing this since trivial changes like this PR can be merged quickly as long as the checks passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107#discussion_r548340317
##########
File path: .asf.yaml
##########
@@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
Review comment:
> Can those people who are not members (committer/PMC) merge directly when the checks passed ? If they can't I think this change of .asf.yml is ok.
Of course they can't, merging needs write access to the repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] fgksgf commented on a change in pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107#discussion_r548340640
##########
File path: .asf.yaml
##########
@@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
Review comment:
Ok, I have no worries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] fgksgf commented on a change in pull request #107: Add changelog for 0.5.0
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #107:
URL: https://github.com/apache/skywalking-python/pull/107#discussion_r548337722
##########
File path: .asf.yaml
##########
@@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
- required_pull_request_reviews:
- dismiss_stale_reviews: true
- required_approving_review_count: 1
Review comment:
How about non-trivial changes ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org