You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/04/04 05:00:56 UTC
Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't
work
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/
-----------------------------------------------------------
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
Bugs: SENTRY-1692
https://issues.apache.org/jira/browse/SENTRY-1692
Repository: sentry
Description
-------
SENTRY-1692 ZK namespace configuration doesn't work
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 00eec4eab066829ae1226d0ba3485eab7bd9eeb2
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 1d79bd1f722505e56941dfd131d782e518515dc4
Diff: https://reviews.apache.org/r/58166/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 58166: SENTRY-1692 ZK namespace configuration
doesn't work
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/#review171080
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On April 4, 2017, 5:03 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58166/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:03 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1692
> https://issues.apache.org/jira/browse/SENTRY-1692
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1692 ZK namespace configuration doesn't work
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 00eec4eab066829ae1226d0ba3485eab7bd9eeb2
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 1d79bd1f722505e56941dfd131d782e518515dc4
>
>
> Diff: https://reviews.apache.org/r/58166/diff/1/
>
>
> Testing
> -------
>
> I tested this manually by running the server with namespace provided in the config.
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58166: SENTRY-1692 ZK namespace configuration
doesn't work
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On April 4, 2017, 6:07 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java
> > Line 96 (original)
> > <https://reviews.apache.org/r/58166/diff/1/?file=1684224#file1684224line96>
> >
> > Not quite follow the change. If we are complete remove namespace here, why do we still keep the namespace config in HAContext? And why do we need it?
I update the JIRA to clarify this. Copying from there:
There are two problems:
1) The namespace used by HAContext shouldn't start with "/", so in the fix we remove the initial slash if it is present
2) The LeaderStatusMonitor shouldn't use prefix at all - it appends "/leader" to the namespace.
The patch addresses both issues.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/#review170957
-----------------------------------------------------------
On April 4, 2017, 5:03 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58166/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:03 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1692
> https://issues.apache.org/jira/browse/SENTRY-1692
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1692 ZK namespace configuration doesn't work
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 00eec4eab066829ae1226d0ba3485eab7bd9eeb2
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 1d79bd1f722505e56941dfd131d782e518515dc4
>
>
> Diff: https://reviews.apache.org/r/58166/diff/1/
>
>
> Testing
> -------
>
> I tested this manually by running the server with namespace provided in the config.
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58166: SENTRY-1692 ZK namespace configuration
doesn't work
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/#review170957
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java
Line 96 (original)
<https://reviews.apache.org/r/58166/#comment243797>
Not quite follow the change. If we are complete remove namespace here, why do we still keep the namespace config in HAContext? And why do we need it?
- Hao Hao
On April 4, 2017, 5:03 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58166/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:03 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1692
> https://issues.apache.org/jira/browse/SENTRY-1692
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1692 ZK namespace configuration doesn't work
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 00eec4eab066829ae1226d0ba3485eab7bd9eeb2
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 1d79bd1f722505e56941dfd131d782e518515dc4
>
>
> Diff: https://reviews.apache.org/r/58166/diff/1/
>
>
> Testing
> -------
>
> I tested this manually by running the server with namespace provided in the config.
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58166: SENTRY-1692 ZK namespace configuration
doesn't work
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/#review171310
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On April 4, 2017, 5:03 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58166/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:03 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: SENTRY-1692
> https://issues.apache.org/jira/browse/SENTRY-1692
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1692 ZK namespace configuration doesn't work
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 00eec4eab066829ae1226d0ba3485eab7bd9eeb2
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 1d79bd1f722505e56941dfd131d782e518515dc4
>
>
> Diff: https://reviews.apache.org/r/58166/diff/1/
>
>
> Testing
> -------
>
> I tested this manually by running the server with namespace provided in the config.
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58166: SENTRY-1692 ZK namespace configuration
doesn't work
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/
-----------------------------------------------------------
(Updated April 4, 2017, 5:03 a.m.)
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, and Na Li.
Bugs: SENTRY-1692
https://issues.apache.org/jira/browse/SENTRY-1692
Repository: sentry
Description
-------
SENTRY-1692 ZK namespace configuration doesn't work
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 00eec4eab066829ae1226d0ba3485eab7bd9eeb2
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 1d79bd1f722505e56941dfd131d782e518515dc4
Diff: https://reviews.apache.org/r/58166/diff/1/
Testing (updated)
-------
I tested this manually by running the server with namespace provided in the config.
Thanks,
Alexander Kolbasov