[GitHub] [accumulo] ctubbsii commented on a change in pull request #1649: Addresses four compaction service follow on issues.

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1649:
URL: https://github.com/apache/accumulo/pull/1649#discussion_r464484830



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -415,6 +415,10 @@
   TSERV_COMPACTION_SERVICE_ROOT_PLANNER("tserver.compaction.major.service.root.planner",
       DefaultCompactionPlanner.class.getName(), PropertyType.CLASSNAME,
       "Compaction planner for root tablet service"),
+  TSERV_COMPACTION_SERVICE_ROOT_RATE_LIMIT("tserver.compaction.major.service.root.rate.limit", "0B",

Review comment:
       > > I worry that we have added far too many new configuration properties for compactions, and that this might create a terrible user experience around compactions.
   > 
   > Could open a new issue and discuss a course of action.
   
   For the larger issue, yes. But I'm struggling to keep up with the pace of all these changes, and am raising the point here, to step back and ask the more narrow question of whether these specific properties are needed. If they are, that's fine... we can move on. But, I don't know if I have the mental capacity to circle back and form a coherent discussion around the larger issue that a separate ticket would serve. The time to do that was probably several weeks ago before the wave of new properties got introduced, and that ship may have sailed.
   
   > 
   > > Also, what does "root" refer to here for this property?
   > 
   > This is a compaction service for the root table.
   
   Okay, cool. Thanks. However, I suppose the point of my feedback wasn't to get a response here, but to get a response in the form of an improved description field in the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org