[GitHub] [helix] narendly commented on a change in pull request #696: Add WAGED rebalancer reset method to clean up cached status.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #696: Add WAGED rebalancer reset method to clean up cached status.
URL: https://github.com/apache/helix/pull/696#discussion_r369906596
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/AssignmentMetadataStore.java
 ##########
 @@ -146,6 +146,17 @@ public boolean persistBestPossibleAssignment(
     return true;
   }
 
+  protected synchronized void resetCache() {
 
 Review comment:
   Nit: I think `clearMetadataStore()` might be a better name for this method because caching isn't really an explicit feature? Or resetMetadataStore()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org