You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Graham Charters (JIRA)" <ji...@apache.org> on 2010/03/09 15:02:27 UTC
[jira] Created: (ARIES-230) Rename eba-maven-plugin to
maven-eba-plugin for consistency
Rename eba-maven-plugin to maven-eba-plugin for consistency
-----------------------------------------------------------
Key: ARIES-230
URL: https://issues.apache.org/jira/browse/ARIES-230
Project: Aries
Issue Type: Improvement
Components: Application
Affects Versions: 0.1
Reporter: Graham Charters
Priority: Trivial
Fix For: 0.1
Rename eba-maven-plugin to maven-eba-plugin for consistency
Also need to change any samples that use the current plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-230) Rename eba-maven-plugin to
maven-eba-plugin for consistency
Posted by "Graham Charters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Graham Charters updated ARIES-230:
----------------------------------
Assignee: Graham Charters
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> -----------------------------------------------------------
>
> Key: ARIES-230
> URL: https://issues.apache.org/jira/browse/ARIES-230
> Project: Aries
> Issue Type: Improvement
> Components: Application
> Affects Versions: 0.1
> Reporter: Graham Charters
> Assignee: Graham Charters
> Priority: Trivial
> Fix For: 0.1
>
>
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> Also need to change any samples that use the current plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-230) Rename eba-maven-plugin to
maven-eba-plugin for consistency
Posted by "Graham Charters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843476#action_12843476 ]
Graham Charters commented on ARIES-230:
---------------------------------------
Thanks for the links, David. It would be nice if the convention were mentioned in the doc that describe how to develop new plugins.
>> I didn't just make up a convention when I named it eba-maven-plugin.
I'd only ever come across plugins named maven-xxx-plugin, including many outside maven, and when talking to others about it, they would always say things like, "is it the maven eba plug?". So from a usability perspective it seemed to make sense to rename.
Thanks for catching this. I do agree it should not have been changed and will revert it back to eba-maven-plugin.
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> -----------------------------------------------------------
>
> Key: ARIES-230
> URL: https://issues.apache.org/jira/browse/ARIES-230
> Project: Aries
> Issue Type: Improvement
> Components: Application
> Affects Versions: 0.1
> Reporter: Graham Charters
> Assignee: Graham Charters
> Priority: Trivial
> Fix For: 0.1
>
>
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> Also need to change any samples that use the current plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-230) Rename eba-maven-plugin to
maven-eba-plugin for consistency
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843366#action_12843366 ]
David Jencks commented on ARIES-230:
------------------------------------
I found http://maven.apache.org/guides/development/guide-plugin-documentation.html
Alan found http://old.nabble.com/maven-%24name-plugin-or-%24name-maven-plugin-artifactId-ts27842424.html#a27842580
I didn't just make up a convention when I named it eba-maven-plugin.
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> -----------------------------------------------------------
>
> Key: ARIES-230
> URL: https://issues.apache.org/jira/browse/ARIES-230
> Project: Aries
> Issue Type: Improvement
> Components: Application
> Affects Versions: 0.1
> Reporter: Graham Charters
> Assignee: Graham Charters
> Priority: Trivial
> Fix For: 0.1
>
>
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> Also need to change any samples that use the current plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-230) Rename eba-maven-plugin to
maven-eba-plugin for consistency
Posted by "Graham Charters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843304#action_12843304 ]
Graham Charters commented on ARIES-230:
---------------------------------------
I did wonder, but there are so many examples which follow the
maven-xxx-plugin, that aren't 'official'. Tuscany has 7, for example
:-S . I had a quick hunt for guidance and found the following link:
http://maven.apache.org/guides/plugin/guide-java-plugin-development.html
. It describes how to create the maven-hello-plugin (using their
convention) and it states the following which suggests both naming
styles are 'official' but doesn't say they should be avoided.
"The "maven-$name-plugin" and "$name-maven-plugin" artifactId patterns
are treated in a special way. If no plugin matches the artifactId
specified on the command line, Maven will try expanding the artifactId
to these patterns in that order. So in the case of our example, you
can use "mvn sample.plugin:hello:sayhi" to run your plugin. Note:
these 2 patterns are used respectively by the official Maven 2 plugins
and the Mojo project plugins."
Can you point me at some guidance to make sure we don't end up with
multiple renames?
Many thanks.
Graham.
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> -----------------------------------------------------------
>
> Key: ARIES-230
> URL: https://issues.apache.org/jira/browse/ARIES-230
> Project: Aries
> Issue Type: Improvement
> Components: Application
> Affects Versions: 0.1
> Reporter: Graham Charters
> Assignee: Graham Charters
> Priority: Trivial
> Fix For: 0.1
>
>
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> Also need to change any samples that use the current plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (ARIES-230) Rename eba-maven-plugin to
maven-eba-plugin for consistency
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed ARIES-230.
------------------------------
Resolution: Invalid
DONT DO THIS
only plugins that are actually in the maven project are supposed to be named maven-foo-plugin. Plugins that are not maintained by maven are supposed to be named foo-maven-plugin. The maven-bundle-plugin and several others are wrongly named.
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> -----------------------------------------------------------
>
> Key: ARIES-230
> URL: https://issues.apache.org/jira/browse/ARIES-230
> Project: Aries
> Issue Type: Improvement
> Components: Application
> Affects Versions: 0.1
> Reporter: Graham Charters
> Assignee: Graham Charters
> Priority: Trivial
> Fix For: 0.1
>
>
> Rename eba-maven-plugin to maven-eba-plugin for consistency
> Also need to change any samples that use the current plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.