You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2026/08/14 06:41:00 UTC
[PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
rishabhdaim opened a new pull request, #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7
…chema header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#issuecomment-5291753663
@bdelacretaz Tested with the example:
```
PARTIAL: Ibiza Command Base Schema
Provides schema elements for the Ibiza Command pattern
TODO: does this pattern work for most the commands that we need?
REQUIRES: ibiza.scalars, ibiza.links
QUERY: -----------------------------------------------------------------------
```
and it is working fine after the changes.
before the fix, it was failing due to `TODO:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke merged PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "schulm (via GitHub)" <gi...@apache.org>.
schulm commented on code in PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#discussion_r3784705979
##########
src/test/java/org/apache/sling/graphql/schema/aggregator/impl/PartialReaderTest.java:
##########
@@ -146,13 +146,39 @@ public void invalidSectionName() throws Exception {
PartialReader.SyntaxException.class,
() -> new PartialReader(
PartialInfo.EMPTY,
- getStringReaderSupplier(String.format("PARTIAL:test\n%s:something\n", invalidName))));
+ getStringReaderSupplier(String.format("%s:something\nPARTIAL:test\n", invalidName))));
final String expected = "Invalid section name 'REQUIRE'";
assertTrue(
String.format("Expected %s in %s", expected, e.getMessage()),
e.getMessage().contains(expected));
}
+ @Test
+ public void unknownSectionLikeLineInsideSectionIsIgnored() throws Exception {
Review Comment:
Suggestion - Add the realistic Ibiza partial under src/test/resources/partials and parse it in a regression
maintainer. Current inline tests are behaviorally sufficient, but don’t document the real-world format. [test-coverage-analyst v0.2.0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#issuecomment-5290486587
@bdelacretaz could you please review and share feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#issuecomment-5290372374
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#issuecomment-5290998668
@bdelacretaz - feedback would be good :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#issuecomment-5291166240
The changes seem to make sense but it took me a while (5 years after I last worked on this module ;-) to understand what's going on. I think it would be much better to demonstrate and test the changes with a new partial example that demonstrate this, under src/test/resources/partials. Ideally we'd have an example there that parses only if the changes of this PR are applied, demonstrating what failed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13309 : relaxed to schema validations to allow ALLCAPS: after s… [sling-org-apache-sling-graphql-schema-aggregator]
Posted by "schulm (via GitHub)" <gi...@apache.org>.
schulm commented on code in PR #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#discussion_r3784705979
##########
src/test/java/org/apache/sling/graphql/schema/aggregator/impl/PartialReaderTest.java:
##########
@@ -146,13 +146,39 @@ public void invalidSectionName() throws Exception {
PartialReader.SyntaxException.class,
() -> new PartialReader(
PartialInfo.EMPTY,
- getStringReaderSupplier(String.format("PARTIAL:test\n%s:something\n", invalidName))));
+ getStringReaderSupplier(String.format("%s:something\nPARTIAL:test\n", invalidName))));
final String expected = "Invalid section name 'REQUIRE'";
assertTrue(
String.format("Expected %s in %s", expected, e.getMessage()),
e.getMessage().contains(expected));
}
+ @Test
+ public void unknownSectionLikeLineInsideSectionIsIgnored() throws Exception {
Review Comment:
Suggstion - Add the realistic Ibiza partial under src/test/resources/partials and parse it in a regression
maintainer. Current inline tests are behaviorally sufficient, but don’t document the real-world format. [test-coverage-analyst v0.2.0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org