[GitHub] [geode] pivotal-jbarrett commented on pull request #5806: GEODE-8763: run benchmark tests up to 5 times

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on pull request #5806:
URL: https://github.com/apache/geode/pull/5806#issuecomment-738466652


   > this looks better. although I think lines 85-97 could be simplified to just:
   > 
   > set -e
   > ./run_against_baseline.sh ...
   > set +e
   
   Not really. `-e` causes errors to bubble up and exit the script, which in this case we want to avoid to loop 5 times, but only on the execution of this line. The logic for checking the iteration found could be simplified if we captured the error code and exited with that code after the 5th iteration. 
   ```
   exit_code=0
   for ... {
     ...
     set +e
     ./run_against...
     set -e
     exit_code = $?
   
     if [[ $exit_code -eq 0 ]]; then
       break;
     fi
   }
   ...
   exit $exit_code
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org