You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/12/06 02:54:07 UTC
[GitHub] [dubbo] codecov-io commented on issue #5435: Fixed the
router problem of application condition router does not take effect.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=h1) Report
> Merging [#5435](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/46d3dad8ff4952244336d90bf5551de84ae1e6e1?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5435 +/- ##
===========================================
- Coverage 61.24% 61.2% -0.05%
Complexity 424 424
===========================================
Files 919 919
Lines 37475 37496 +21
Branches 5460 5463 +3
===========================================
- Hits 22952 22948 -4
- Misses 12013 12033 +20
- Partials 2510 2515 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ster/router/condition/config/ListenableRouter.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVJvdXRlci5qYXZh) | `21.21% <ø> (-12.13%)` | `0 <0> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `66.66% <60%> (-33.34%)` | `0 <0> (ø)` | |
| [...rpc/cluster/router/condition/config/AppRouter.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwUm91dGVyLmphdmE=) | `83.33% <81.81%> (-16.67%)` | `0 <0> (ø)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `56.81% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==) | `70.83% <0%> (-8.34%)` | `0% <0%> (ø)` | |
| [...he/dubbo/common/threadpool/ThreadlessExecutor.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9UaHJlYWRsZXNzRXhlY3V0b3IuamF2YQ==) | `55.55% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `53.75% <0%> (-3.75%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `65.45% <0%> (-3.64%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/dubbo/pull/5435/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=footer). Last update [46d3dad...fedf65b](https://codecov.io/gh/apache/dubbo/pull/5435?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5435 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org