You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 23:47:28 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #3051: Move CSV test data (#3044)

tustvold opened a new pull request, #3051:
URL: https://github.com/apache/arrow-rs/pull/3051

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of #3044
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   In #3044 I originally didn't move the test data, following #3049 my thoughts on this have changed and I think it is better to keep these tests closer to the code they are tests for.
   
   
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3051: Move CSV test data (#3044)

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3051:
URL: https://github.com/apache/arrow-rs/pull/3051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #3051: Move CSV test data (#3044)

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3051:
URL: https://github.com/apache/arrow-rs/pull/3051#issuecomment-1312040498

   Benchmark runs are scheduled for baseline = 01396822eb68a90565cf8b177aab4b0ce8af40e1 and contender = 02a3f5cd24ef586cdf57af1f06cad662a094a9af. 02a3f5cd24ef586cdf57af1f06cad662a094a9af is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bb418dd9eb1b45538fd97ba381c03495...9de06dfa8fb84578afc548436cf305d8/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/87e569a30b044ea2b57a10d2baa8f209...18b0f6a7667d4eac95619990da1c34e5/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/78b9f82ccd40480695a9d988fb70fe8f...becc04ec9398488fa60fd31a64669cf9/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/685d324342c343938483506624a2220d...f1e95f61174c4283929e1a18adef9500/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3051: Move CSV test data (#3044)

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3051:
URL: https://github.com/apache/arrow-rs/pull/3051#issuecomment-1307994001

   Needs test fix from #3049, marking as draft for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org