Build script and issues with spaces in paths

[Justin Mclean <ju...@classsoftware.com>]

Hi,

It seems there's a relative easy fix. In the arg line of an ant exec task you just use value="" for a single parameter rather than line="".

I have tested this with "ant main" and "ant checkintests" on OSX with a paths that contains spaces.

I've checked in the patch to the trunk. If this causes any issues/side effects at all please revert /override my changes.

Here's the patch file as you can see there are minimal changes.


### Eclipse Workspace Patch 1.0
#P Apache Flex Clean
Index: build.xml
===================================================================
--- build.xml	(revision 1347211)
+++ build.xml	(working copy)
@@ -1187,7 +1187,7 @@
         <!-- run the component smoke  -->
         <echo message="launching player and swf"/>
         <exec executable="${flash.player}" dir="${basedir}/frameworks" failonerror="true">
-            <arg line="${basedir}/frameworks/tests/basicTests/BasicTests.swf"/>
+            <arg value="${basedir}/frameworks/tests/basicTests/BasicTests.swf"/>
         </exec>
         <!-- halt if there was an error -->
         <antcall target="mustellaresultsparser"/>
@@ -1240,7 +1240,7 @@
         <!-- run the component smoke  -->
         <echo message="launching player and swf"/>
         <exec executable="${flash.player}" dir="${basedir}/frameworks" failonerror="true">
-            <arg line="${basedir}/frameworks/tests/componentSmoke/componentSmoke2.swf"/>
+            <arg value="${basedir}/frameworks/tests/componentSmoke/componentSmoke2.swf"/>
         </exec>
         <!-- halt if there was an error -->
         <antcall target="mustellaresultsparser"/>
@@ -1266,7 +1266,7 @@
         <!-- run the component smoke  -->
         <echo message="launching player and swf"/>
         <exec executable="${flash.player}" dir="${basedir}/frameworks">
-            <arg line="${basedir}/frameworks/tests/checkinapp/checkinapp.swf"/>
+            <arg value="${basedir}/frameworks/tests/checkinapp/checkinapp.swf"/>
         </exec>
         <!-- halt if there was an error -->
         <antcall target="mustellaresultsparser"/>
@@ -1288,7 +1288,7 @@
         <!-- run the component smoke  -->
         <echo message="launching player and swf"/>
         <exec executable="${flash.player}" dir="${basedir}/frameworks">
-            <arg line="${basedir}/frameworks/tests/graphics/GraphicTags_checkin.swf"/>
+            <arg value="${basedir}/frameworks/tests/graphics/GraphicTags_checkin.swf"/>
         </exec>
         <!-- halt if there was an error -->
         <antcall target="mustellaresultsparser"/>
@@ -1310,7 +1310,7 @@
         <!-- run the component smoke  -->
         <echo message="launching player and swf"/>
         <exec executable="${flash.player}" dir="${basedir}/frameworks">
-            <arg line="${basedir}/frameworks/tests/spark/sparkTest.swf"/>
+            <arg value="${basedir}/frameworks/tests/spark/sparkTest.swf"/>
         </exec>
         <!-- halt if there was an error -->
         <antcall target="mustellaresultsparser"/>
@@ -1332,7 +1332,7 @@
         <!-- run the component smoke  -->
         <echo message="launching player and swf"/>
         <exec executable="${flash.player}" dir="${basedir}/frameworks">
-            <arg line="${basedir}/frameworks/tests/fxgCompile/fxgCompileTest.swf"/>
+            <arg value="${basedir}/frameworks/tests/fxgCompile/fxgCompileTest.swf"/>
         </exec>
         <!-- halt if there was an error -->
         <antcall target="mustellaresultsparser"/>
@@ -1428,7 +1428,8 @@
             <classpath>
                 <pathelement location="${basedir}/tools/dependencychecker"/>
             </classpath>
-            <arg line="${basedir}/frameworks/libs/framework.swc frameworkSwcExceptionsList.txt"/>
+            <arg value="${basedir}/frameworks/libs/framework.swc" />
+        	<arg value="frameworkSwcExceptionsList.txt"/>
         </java>
     </target>

Thanks,
Justin