You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/16 05:57:16 UTC
[GitHub] [orc] autumnust opened a new pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
autumnust opened a new pull request #910:
URL: https://github.com/apache/orc/pull/910
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
While working on another PR, I found the head of main failed in GA with the failure like below.
`Error: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-java-version) on project orc: Execution enforce-java-version of goal org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce: java.lang.ExceptionInInitializerError: null
Error: -----------------------------------------------------
Error: realm = plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1
Error: strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
Error: urls[0] = file:/Users/runner/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar
Error: urls[1] = file:/Users/runner/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
Error: urls[2] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
Error: urls[3] = file:/Users/runner/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
Error: urls[4] = file:/Users/runner/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
Error: urls[5] = file:/Users/runner/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
Error: urls[6] = file:/Users/runner/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
Error: urls[7] = file:/Users/runner/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
Error: urls[8] = file:/Users/runner/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
Error: urls[9] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
Error: urls[10] = file:/Users/runner/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
Error: urls[11] = file:/Users/runner/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
Error: urls[12] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
Error: urls[13] = file:/Users/runner/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.jar
Error: urls[14] = file:/Users/runner/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.4.1/enforcer-api-1.4.1.jar
Error: urls[15] = file:/Users/runner/.m2/repository/org/apache/maven/enforcer/enforcer-rules/1.4.1/enforcer-rules-1.4.1.jar
Error: urls[16] = file:/Users/runner/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
Error: urls[17] = file:/Users/runner/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar
Error: urls[18] = file:/Users/runner/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar
Error: urls[19] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
Error: urls[20] = file:/Users/runner/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
Error: urls[21] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-6/plexus-i18n-1.0-beta-6.jar
Error: urls[22] = file:/Users/runner/.m2/repository/org/apache/maven/plugin-testing/maven-plugin-testing-harness/1.3/maven-plugin-testing-harness-1.3.jar
Error: urls[23] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-archiver/2.2/plexus-archiver-2.2.jar
Error: urls[24] = file:/Users/runner/.m2/repository/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.jar
Error: urls[25] = file:/Users/runner/.m2/repository/junit/junit/4.11/junit-4.11.jar
Error: urls[26] = file:/Users/runner/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar
Error: Number of foreign imports: 1
Error: import: Entry[import from realm ClassRealm[maven.api, parent: null]]
Error:
Error: -----------------------------------------------------: begin 0, end 3, length 2
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
make[2]: *** [java/shims/orc-shims-1.8.0-SNAPSHOT.jar] Error 1
make[1]: *** [java/CMakeFiles/java_build.dir/all] Error 2
make: *** [all] Error 2
Error: Process completed with exit code 2.`
Google a bit and found a similar issue: https://github.com/apache/accumulo-proxy/pull/19
This PR is a draft to see if the same change could work here ( since I don't have specific env like failed CI)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920640227
Actually, this is very unfortunate situation because we release Apache ORC 1.7.0. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920663700
Do you have any reference for that? Actually, Java community is a little notorious because they don't care about that many programs, @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920734525
Ya, that could be one reason to raise the `min.hadoop.version`.
BTW, for Java 17 testing, I'll add a `profile` as a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920640227
Actually, this is very unfortunate situation because we released Apache ORC 1.7.0. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #910:
URL: https://github.com/apache/orc/pull/910#discussion_r709855398
##########
File path: java/pom.xml
##########
@@ -90,6 +90,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
+ <version>3.0.0-M3</version>
Review comment:
We can use `3.0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920630496
I think the JDK17 General-Availability Release was released two days ago. Github workflow updated JDK17. Now System.getProperty("java.version") returns "17" which causes a lot of program exceptions.
```
Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
Maven home: /usr/share/apache-maven-3.8.2
Java version: 17, vendor: Azul Systems, Inc., runtime: /opt/hostedtoolcache/jdk/17.0.0/x64
```
For example org.apache.hadoop.util.Shell.java
```
private static boolean IS_JAVA7_OR_ABOVE =
System.getProperty("java.version").substring(0, 3).compareTo("1.7") >= 0;
```
java.lang.StringIndexOutOfBoundsException: String index out of range: 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #910:
URL: https://github.com/apache/orc/pull/910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920675377
Oh, I misread the message and delete my previous comment~ If you received them via the email, please forget about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun removed a comment on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun removed a comment on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920674347
Got it. Then, that's a big relief to me. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920675377
Oh, I misread the message and deleted my previous comment~ If you received them via the email, please forget about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920674347
Got it. Then, that's a big relief to me. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920685538
Yes, there is no code directly related to java version in ORC, the example I gave is from hadoop 2.2. It has been fixed at https://issues.apache.org/jira/browse/HADOOP-14586. Don't worry too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920673469
@dongjoon-hyun I remember a similar thing happening with JDK 9. I always thought it was the JDK that officially solved the version number problem. I just googled it and I was wrong. : (
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920662559
> Actually, this is very unfortunate situation because we released Apache ORC 1.7.0. :(
@dongjoon-hyun, probably JDK official will fix this problem, because there are many programs involved. It should not be necessary for each program to upgrade the Java version judgment. So don't worry about the ORC 1.7.0 compatibility issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920636221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: [DRAFT] Attempting to fix the maven enforcer issue in main branch
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920636221
Oh, I didn't saw your PR and make a PR to upgrade Java 17.
- https://github.com/apache/orc/pull/911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920679244
BTW, this might be only our test framework issue. Let me dig more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #910: ORC-1001: Bump maven-enforcer-plugin to 3.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #910:
URL: https://github.com/apache/orc/pull/910#issuecomment-920662643
BTW, `maven-enforcer-plugin` issue exists only at `main`. I landed at `main` only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org