[cassandra] branch cassandra-3.0 updated: Elaborate on why we need to recycle CL segments when dropping tables

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maedhroz pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
     new 35446dc  Elaborate on why we need to recycle CL segments when dropping tables
35446dc is described below

commit 35446dca270ba570c5e523fd80ea5c223dfbeccc
Author: Aleksandr Sorokoumov <al...@gmail.com>
AuthorDate: Mon Sep 27 15:33:32 2021 +0200

    Elaborate on why we need to recycle CL segments when dropping tables
    
    patch by Aleksandr Sorokoumov; reviewed by Caleb Rackliffe and Benjamin Lerer for CASSANDRA-16986
---
 .../org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java b/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
index c24aa12..291616d 100644
--- a/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
+++ b/src/java/org/apache/cassandra/db/commitlog/CommitLogSegmentManager.java
@@ -291,7 +291,8 @@ public class CommitLogSegmentManager
      * Switch to a new segment, regardless of how much is left in the current one.
      *
      * Flushes any dirty CFs for this segment and any older segments, and then recycles
-     * the segments
+     * the segments. This is necessary to avoid resurrecting data during replay if a user
+     * creates a new table with the same name and ID. See CASSANDRA-16986 for more details.
      */
     void forceRecycleAll(Iterable<UUID> droppedCfs)
     {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org