You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by an...@apache.org on 2008/04/18 10:31:59 UTC
svn commit: r649406 - in
/jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav:
ItemInfoImpl.java NodeInfoImpl.java PropertyInfoImpl.java
RepositoryServiceImpl.java
Author: angela
Date: Fri Apr 18 01:31:56 2008
New Revision: 649406
URL: http://svn.apache.org/viewvc?rev=649406&view=rev
Log:
JCR-1539: SPI: Get rid of unused method ItemInfo.getParentId()
Modified:
jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/ItemInfoImpl.java
jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/NodeInfoImpl.java
jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/PropertyInfoImpl.java
jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java
Modified: jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/ItemInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/ItemInfoImpl.java?rev=649406&r1=649405&r2=649406&view=diff
==============================================================================
--- jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/ItemInfoImpl.java (original)
+++ jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/ItemInfoImpl.java Fri Apr 18 01:31:56 2008
@@ -36,13 +36,10 @@
private static Logger log = LoggerFactory.getLogger(ItemInfoImpl.class);
- private final NodeId parentId;
private final Path path;
- public ItemInfoImpl(NodeId parentId, DavPropertySet propSet, NamePathResolver resolver)
+ public ItemInfoImpl(DavPropertySet propSet, NamePathResolver resolver)
throws NameException, NamespaceException {
- // set parentId
- this.parentId = parentId;
DavProperty pathProp = propSet.get(ItemResourceConstants.JCR_PATH);
String jcrPath = pathProp.getValue().toString();
@@ -50,11 +47,9 @@
}
- public NodeId getParentId() {
- return parentId;
- }
-
-
+ /**
+ * @see ItemInfo#getPath()
+ */
public Path getPath() {
return path;
}
Modified: jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/NodeInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/NodeInfoImpl.java?rev=649406&r1=649405&r2=649406&view=diff
==============================================================================
--- jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/NodeInfoImpl.java (original)
+++ jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/NodeInfoImpl.java Fri Apr 18 01:31:56 2008
@@ -54,9 +54,9 @@
private final List references = new ArrayList();
private final List propertyIds = new ArrayList();
- public NodeInfoImpl(NodeId id, NodeId parentId, DavPropertySet propSet,
+ public NodeInfoImpl(NodeId id, DavPropertySet propSet,
NamePathResolver resolver) throws RepositoryException, NameException {
- super(parentId, propSet, resolver);
+ super(propSet, resolver);
// set id
this.id = id;
Modified: jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/PropertyInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/PropertyInfoImpl.java?rev=649406&r1=649405&r2=649406&view=diff
==============================================================================
--- jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/PropertyInfoImpl.java (original)
+++ jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/PropertyInfoImpl.java Fri Apr 18 01:31:56 2008
@@ -16,14 +16,13 @@
*/
package org.apache.jackrabbit.spi2dav;
-import org.apache.jackrabbit.spi.commons.conversion.NameException;
-import org.apache.jackrabbit.spi.commons.conversion.NamePathResolver;
import org.apache.jackrabbit.spi.Name;
-import org.apache.jackrabbit.spi.NodeId;
import org.apache.jackrabbit.spi.PropertyId;
import org.apache.jackrabbit.spi.PropertyInfo;
import org.apache.jackrabbit.spi.QValue;
import org.apache.jackrabbit.spi.QValueFactory;
+import org.apache.jackrabbit.spi.commons.conversion.NameException;
+import org.apache.jackrabbit.spi.commons.conversion.NamePathResolver;
import org.apache.jackrabbit.spi.commons.value.ValueFormat;
import org.apache.jackrabbit.webdav.DavException;
import org.apache.jackrabbit.webdav.jcr.ItemResourceConstants;
@@ -51,12 +50,12 @@
private boolean isMultiValued;
private QValue[] values;
- public PropertyInfoImpl(PropertyId id, NodeId parentId, DavPropertySet propSet,
+ public PropertyInfoImpl(PropertyId id, DavPropertySet propSet,
NamePathResolver resolver, ValueFactory valueFactory,
QValueFactory qValueFactory)
throws RepositoryException, DavException, IOException, NameException {
- super(parentId, propSet, resolver);
+ super(propSet, resolver);
// set id
this.id = id;
Modified: jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java?rev=649406&r1=649405&r2=649406&view=diff
==============================================================================
--- jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java (original)
+++ jackrabbit/sandbox/spi/spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java Fri Apr 18 01:31:56 2008
@@ -841,7 +841,7 @@
SessionInfo sessionInfo,
NamePathResolver resolver) throws NameException, RepositoryException {
NodeId id = uriResolver.buildNodeId(parentId, nodeResponse, sessionInfo.getWorkspaceName(), getNamePathResolver(sessionInfo));
- NodeInfoImpl nInfo = new NodeInfoImpl(id, parentId, propSet, resolver);
+ NodeInfoImpl nInfo = new NodeInfoImpl(id, propSet, resolver);
if (propSet.contains(ItemResourceConstants.JCR_REFERENCES)) {
HrefProperty refProp = new HrefProperty(propSet.get(ItemResourceConstants.JCR_REFERENCES));
Iterator hrefIter = refProp.getHrefs().iterator();
@@ -945,7 +945,7 @@
PropertyId id = uriResolver.buildPropertyId(parentId, responses[0], sessionInfo.getWorkspaceName(), getNamePathResolver(sessionInfo));
NamePathResolver resolver = getNamePathResolver(sessionInfo);
- PropertyInfo pInfo = new PropertyInfoImpl(id, parentId, propSet,
+ PropertyInfo pInfo = new PropertyInfoImpl(id, propSet,
resolver, valueFactory, getQValueFactory());
return pInfo;
} catch (IOException e) {