You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/28 06:53:36 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #11126: [Transaction] Transaction delete marker monitor.

eolivelli commented on a change in pull request #11126:
URL: https://github.com/apache/pulsar/pull/11126#discussion_r659523201



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -447,6 +448,13 @@ public void start() throws Exception {
             }
         }
 
+        if (pulsar.getConfiguration().isTransactionCoordinatorEnabled()) {
+            this.transactionBufferDeleteMarkerMonitor = Executors

Review comment:
       can you please "shutdown" this Executor service on BrokerService close ?
   
   I also cannot find the shutdown for these other threadpools: topicPublishRateLimiterMonitor, brokerPublishRateLimiterMonitor, deduplicationSnapshotMonitor




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org