You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/10/23 19:37:02 UTC
Review Request 71661: Added missing header guards for poll_socket.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71661/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
Bugs: MESOS-10009
https://issues.apache.org/jira/browse/MESOS-10009
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/poll_socket.hpp 881dab1da4f8dfa7826d82398a989fd23cc2262e
Diff: https://reviews.apache.org/r/71661/diff/1/
Testing
-------
cmake --build . --target process
Thanks,
Joseph Wu
Re: Review Request 71661: Added missing header guards for
poll_socket.hpp.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71661/
-----------------------------------------------------------
(Updated Dec. 10, 2019, 3:50 p.m.)
Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
Changes
-------
Elongated the header guard.
Bugs: MESOS-10009
https://issues.apache.org/jira/browse/MESOS-10009
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/poll_socket.hpp 881dab1da4f8dfa7826d82398a989fd23cc2262e
Diff: https://reviews.apache.org/r/71661/diff/2/
Changes: https://reviews.apache.org/r/71661/diff/1-2/
Testing
-------
cmake --build . --target process
Thanks,
Joseph Wu
Re: Review Request 71661: Added missing header guards for
poll_socket.hpp.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71661/#review218657
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71661/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2019, 7:37 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-10009
> https://issues.apache.org/jira/browse/MESOS-10009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/poll_socket.hpp 881dab1da4f8dfa7826d82398a989fd23cc2262e
>
>
> Diff: https://reviews.apache.org/r/71661/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target process
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71661: Added missing header guards for
poll_socket.hpp.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71661/#review218796
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/poll_socket.hpp
Lines 13-14 (patched)
<https://reviews.apache.org/r/71661/#comment306664>
Could we prefix this with `PROCESS_`? We do that in some files (see semaphore.hpp, for example) to disambiguate libprocess headers from others.
```
#ifndef __PROCESS_POLL_SOCKET__
#define __PROCESS_POLL_SOCKET__
```
- Greg Mann
On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71661/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2019, 7:37 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-10009
> https://issues.apache.org/jira/browse/MESOS-10009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/poll_socket.hpp 881dab1da4f8dfa7826d82398a989fd23cc2262e
>
>
> Diff: https://reviews.apache.org/r/71661/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target process
>
>
> Thanks,
>
> Joseph Wu
>
>