[jira] [Updated] (LUCENE-4615) Remove Int/FloatArrayAllocator from facet module?

["Shai Erera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-4615:
-------------------------------

    Attachment: LUCENE-4615.patch

Patch replaces Int/FloatArrayAllocator by ArraysPool and introduces a new ReusingFacetArrays. StandardFacetsAccumulator takes FacetArrays (or none) instead of the allocators.

Thanks Gilad for helping to write this !

All tests pass. I think it's ready to commit
                
> Remove Int/FloatArrayAllocator from facet module?
> -------------------------------------------------
>
>                 Key: LUCENE-4615
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4615
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>         Attachments: LUCENE-4615.patch
>
>
> Spinoff from LUCENE-4600.
> It makes me nervous to have allocation tied to our public APIs ... and the ability for Int/FloatArrayAllocator to hold onto N arrays indefinitely makes me even more nervous.  I think we should just trust java/GC to do their job here and free the storage as soon as faceting is done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org