You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/03/27 07:42:57 UTC

[GitHub] [ignite] SomeFire commented on a change in pull request #4922: IGNITE-9560

SomeFire commented on a change in pull request #4922: IGNITE-9560
URL: https://github.com/apache/ignite/pull/4922#discussion_r269435931
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/security/OperationSecurityContext.java
 ##########
 @@ -17,44 +17,30 @@
 
 package org.apache.ignite.internal.processors.security;
 
-import org.jetbrains.annotations.Nullable;
-
 /**
- * Thread-local security context.
+ *
  */
-public class SecurityContextHolder {
-    /** Context. */
-    private static final ThreadLocal<SecurityContext> CTX = new ThreadLocal<>();
+public class OperationSecurityContext implements AutoCloseable {
+    /** Ignite Security processor. */
+    private final IgniteSecurityProcessor proc;
 
-    /**
-     * Get security context.
-     *
-     * @return Security context.
-     */
-    @Nullable public static SecurityContext get() {
-        return CTX.get();
-    }
+    /** Security context. */
+    private final SecurityContext secCtx;
 
 Review comment:
   Please, rename it to `prevSecCtx`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services