[GitHub] [helix] micahstubbs commented on a diff in pull request #2054: upgrade helix-front to Angular 13

[GitBox <gi...@apache.org>]

micahstubbs commented on code in PR #2054:
URL: https://github.com/apache/helix/pull/2054#discussion_r853490814


##########
helix-front/angular.json:
##########
@@ -16,7 +16,12 @@
             "outputPath": "dist/public",
             "assets": ["client/assets/", "client/favicon.ico"],
             "scripts": [],
-            "styles": ["client/styles.scss", "client/theme.scss"]
+            "styles": ["client/styles.scss", "client/theme.scss"],
+            "stylePreprocessorOptions": {
+              "includePaths": [
+                "client/"
+              ]
+            }

Review Comment:
   This change is recommended by this [StackOverflow Answer from earlier today](https://stackoverflow.com/a/71922508/1732222). 
   
   
   However, I still see this error: 
   
   ```bash
   ./client/main.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
   Error: Transform failed with 1 error:
   helix/helix-front/client/app/cluster/cluster-list/cluster-list.component.scss:17:100: ERROR: Unterminated string token
       at helix/helix-front/node_modules/@ngtools/webpack/src/ivy/loader.js:81:18
       at runMicrotasks (<anonymous>)
       at processTicksAndRejections (internal/process/task_queues.js:97:5)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org