[jira] [Commented] (TIKA-2667) Upgrade jmatio to 1.3

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512016#comment-16512016 ] 

Uwe Schindler commented on TIKA-2667:
-------------------------------------

Hi,

I just looked at your code change in jmatio. The AccessController.doPrivileged() needs to be around the static initializer because the setAccessible(true) is now done there (early). While calling the "compiled" cleaner, it can then be sure that it works. Do you think it is a good idea to throw runtime exception in the initializer if it fails? This is too risky, what happens if somebody uses a too new JDK?

On the place where it actually calls the created cleaner instance, no doPrivileged is needed (it's already in the implementation, so done 2 times).

Should I open a bug on your fork?

Uwe

> Upgrade jmatio to 1.3 
> ----------------------
>
>                 Key: TIKA-2667
>                 URL: https://issues.apache.org/jira/browse/TIKA-2667
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Trivial
>
> jmatio 1.3 includes an upgrade to clean MappedByteBuffers in Java 8->11-ea, thanks to a copy/paste from Lucene.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)